no-commonjs: Fix false positive when exports is in scope

Fixes #940
import-js · Nov 29, 2017 · 7383977 · 7383977
1 parent b839641
commit 7383977
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/rules/no-commonjs.js b/src/rules/no-commonjs.js
@@ -36,7 +36,12 @@ module.exports = {
 
         // exports.
         if (node.object.name === 'exports') {
-          context.report({ node, message: EXPORT_MESSAGE })
+          const isInScope = context.getScope()
+            .variables
+            .some(variable => variable.name === 'exports')
+          if (! isInScope) {
+            context.report({ node, message: EXPORT_MESSAGE })
+          }
         }
 
       },

diff --git a/tests/src/rules/no-commonjs.js b/tests/src/rules/no-commonjs.js
@@ -17,6 +17,15 @@ ruleTester.run('no-commonjs', require('rules/no-commonjs'), {
     // exports
     { code: 'export default "x"', parserOptions: { sourceType: 'module' } },
     { code: 'export function house() {}', parserOptions: { sourceType: 'module' } },
+    {
+      code:
+      'function someFunc() {\n'+
+      '  const exports = someComputation();\n'+
+      '\n'+
+      '  expect(exports.someProp).toEqual({ a: \'value\' });\n'+
+      '}',
+      parserOptions: { sourceType: 'module' },
+    },
 
     // allowed requires
     { code: 'function a() { var x = require("y"); }' }, // nested requires allowed