Handle edge-case

import-js · Oct 13, 2017 · 7751bc3 · 7751bc3 · graingert · Oct 13, 2017
1 parent ba36909
commit 7751bc3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/rules/no-useless-path-segments.js b/src/rules/no-useless-path-segments.js
@@ -37,6 +37,13 @@ module.exports = {
 
   create: function (context) {
     const currentDir = path.dirname(context.getFilename())
+    const resolvesToSameModule = (path1, path2) => {
+      try {
+        return require.resolve((path1)) === require.resolve((path2))
+      } catch(e) {
+        return true
+      }
+    }
 
     function checkSourceValue(source) {
       const { value } = source
@@ -54,7 +61,7 @@ module.exports = {
       }
 
       const normed = normalize(value)
-      if (normed !== value) {
+      if (normed !== value && resolvesToSameModule(value, normed)) {
         return report(normed)
       }
 

diff --git a/tests/files/bar/index.js b/tests/files/bar/index.js
@@ -0,0 +1 @@
+export default 4
diff --git a/tests/src/rules/no-useless-path-segments.js b/tests/src/rules/no-useless-path-segments.js
@@ -44,8 +44,8 @@ function runResolverTests(resolver) {
         errors: [ 'Useless path segments for "../", should be ".."'],
       }),
       test({
-        code: 'import "./files//malformed"',
-        errors: [ 'Useless path segments for "./files//malformed", should be "./files/malformed"'],
+        code: 'import "./deep//a"',
+        errors: [ 'Useless path segments for "./deep//a", should be "./deep/a"'],
       }),
      ],
    })