Remove regular expression support from no-extraneous-dependencies.

docs/rules/no-extraneous-dependencies.md

@@ -25,25 +25,13 @@ You can also use globs instead of literal booleans:
 "import/no-extraneous-dependencies": ["error", {"devDependencies": "*.test.js"}]
 ```
 
-You can also use regular expressions instead of literal booleans or globs (note: the string must begin and end with `/`):
+When using a glob, the setting will be activated if the name of the file being linted matches the given glob. In addition, you can use an array to specify multiple globs:
 
 ```js
-"import/no-extraneous-dependencies": ["error", {"devDependencies": "/test|spec/"}]
+"import/no-extraneous-dependencies": ["error", {"devDependencies": ['*.test.js', '*.spec.js']}]
 ```
 
-If you are using JavaScript configuration (e.g., `.eslintrc.js`), then you can use a RegExp literal instead of a string:
-
-```js
-"import/no-extraneous-dependencies": ["error", {"devDependencies": /test|spec/}]
-```
-
-When using a glob or regular expression, the setting will be activated if the name of the file being linted matches the given glob or regular expression. In addition, you can use an array to specify multiple globs or regular expressions:
-
-```js
-"import/no-extraneous-dependencies": ["error", {"devDependencies": [/test/, '/spec/', '*.test.js', '*.spec.js']}]
-```
-
-When using an array of globs or regular expressions, the setting will be activated if the name of the file being linted matches a single glob or regular expression in the array.
+When using an array of globs, the setting will be activated if the name of the file being linted matches a single glob in the array.
 
 ## Rule Details
 

src/rules/no-extraneous-dependencies.js

@@ -78,20 +78,7 @@ function testConfig(config, filename) {
     return config
   }
   // Account for the possibility of an array for multiple configuration
-  return [].concat(config).some(c => {
-    if (typeof c === 'object') {
-      // `c` is a literal RegExp
-      return c.test(filename)
-    }
-    // By this point `c` must be a string.
-    if (/^\/.+\/$/.test(c)) {
-      // `c` is a string representation of a RegExp.
-      const pattern = new RegExp(c.substring(1, c.length - 1))
-      return pattern.test(filename)
-    }
-    // `c` must be a string representing a glob
-    return minimatch(filename, c)
-  })
+  return [].concat(config).some(c =>  minimatch(filename, c))
 }
 
 module.exports = function (context) {
@@ -126,9 +113,9 @@ module.exports.schema = [
   {
     'type': 'object',
     'properties': {
-      'devDependencies': { 'type': ['boolean', 'string', 'object', 'array'] },
-      'optionalDependencies': { 'type': ['boolean', 'string', 'object', 'array'] },
-      'peerDependencies': { 'type': ['boolean', 'string', 'object', 'array'] },
+      'devDependencies': { 'type': ['boolean', 'string', 'array'] },
+      'optionalDependencies': { 'type': ['boolean', 'string', 'array'] },
+      'peerDependencies': { 'type': ['boolean', 'string', 'array'] },
     },
     'additionalProperties': false,
   },

tests/src/rules/no-extraneous-dependencies.js

@@ -35,16 +35,6 @@ ruleTester.run('no-extraneous-dependencies', rule, {
       code: 'import "importType"',
       settings: { 'import/resolver': { node: { paths: [ path.join(__dirname, '../../files') ] } } },
     }),
-    test({
-      code: 'import chai from "chai"',
-      options: [{devDependencies: /test|spec/}],
-      filename: 'foo.test.js',
-    }),
-    test({
-      code: 'import chai from "chai"',
-      options: [{devDependencies: '/test|spec/'}],
-      filename: 'foo.spec.js',
-    }),
     test({
       code: 'import chai from "chai"',
       options: [{devDependencies: '*.spec.js'}],
@@ -55,11 +45,6 @@ ruleTester.run('no-extraneous-dependencies', rule, {
       options: [{devDependencies: ['*.test.js', '*.spec.js']}],
       filename: 'foo.spec.js',
     }),
-    test({
-      code: 'import chai from "chai"',
-      options: [{devDependencies: [/\.test\.js$/, /\.spec\.js$/]}],
-      filename: 'foo.spec.js',
-    }),
   ],
   invalid: [
     test({
@@ -114,24 +99,6 @@ ruleTester.run('no-extraneous-dependencies', rule, {
         message: '\'glob\' should be listed in the project\'s dependencies, not devDependencies.',
       }],
     }),
-    test({
-      code: 'import chai from "chai"',
-      options: [{devDependencies: /test|spec/}],
-      filename: 'foo.tes.js',
-      errors: [{
-        ruleId: 'no-extraneous-dependencies',
-        message: '\'chai\' should be listed in the project\'s dependencies, not devDependencies.',
-      }],
-    }),
-    test({
-      code: 'import chai from "chai"',
-      options: [{devDependencies: '/test|spec/'}],
-      filename: 'foo.tes.js',
-      errors: [{
-        ruleId: 'no-extraneous-dependencies',
-        message: '\'chai\' should be listed in the project\'s dependencies, not devDependencies.',
-      }],
-    }),
     test({
       code: 'import chai from "chai"',
       options: [{devDependencies: '*.test.js'}],
@@ -143,7 +110,7 @@ ruleTester.run('no-extraneous-dependencies', rule, {
     }),
     test({
       code: 'import chai from "chai"',
-      options: [{devDependencies: ['*.test.js', /test\.js$/, '/test/']}],
+      options: [{devDependencies: ['*.test.js', '*.spec.js']}],
       filename: 'foo.tes.js',
       errors: [{
         ruleId: 'no-extraneous-dependencies',