[Fix] detect extraneous deps even when there are none in the first place

Fixes #1161
import-js · Aug 17, 2018 · b0b6125 · b0b6125
1 parent 5931141
commit b0b6125
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/rules/no-extraneous-dependencies.js b/src/rules/no-extraneous-dependencies.js
@@ -176,11 +176,7 @@ module.exports = {
   create: function (context) {
     const options = context.options[0] || {}
     const filename = context.getFilename()
-    const deps = getDependencies(context, options.packageDir)
-
-    if (!deps) {
-      return {}
-    }
+    const deps = getDependencies(context, options.packageDir) || extractDepFields({})
 
     const depsOptions = {
       allowDevDeps: testConfig(options.devDependencies, filename) !== false,

diff --git a/tests/src/rules/no-extraneous-dependencies.js b/tests/src/rules/no-extraneous-dependencies.js
@@ -17,6 +17,7 @@ const packageFileWithSyntaxErrorMessage = (() => {
 const packageDirWithFlowTyped = path.join(__dirname, '../../files/with-flow-typed')
 const packageDirMonoRepoRoot = path.join(__dirname, '../../files/monorepo')
 const packageDirMonoRepoWithNested = path.join(__dirname, '../../files/monorepo/packages/nested-package')
+const packageDirWithEmpty = path.join(__dirname, '../../files/empty')
 
 ruleTester.run('no-extraneous-dependencies', rule, {
   valid: [
@@ -263,5 +264,14 @@ ruleTester.run('no-extraneous-dependencies', rule, {
         message: "'react' should be listed in the project's dependencies. Run 'npm i -S react' to add it",
       }],
     }),
+    test({
+      code: 'import "react";',
+      filename: path.join(packageDirWithEmpty, 'index.js'),
+      options: [{packageDir: packageDirWithEmpty}],
+      errors: [{
+        ruleId: 'no-extraneous-dependencies',
+        message: "'react' should be listed in the project's dependencies. Run 'npm i -S react' to add it",
+      }],
+    }),
   ]
 })