[no-internal-modules] allow importing @-scoped modules

import-js · Sep 24, 2016 · b8663fd · b8663fd
1 parent e3c41ca
commit b8663fd
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/src/rules/no-internal-modules.js b/src/rules/no-internal-modules.js
@@ -54,7 +54,8 @@ module.exports = {
           }
         }, [])
 
-      if (steps.length <= 1) return false
+      const nonScopeSteps = steps.filter(step => step.indexOf('@') !== 0)
+      if (nonScopeSteps.length <= 1) return false
 
       // before trying to resolve, see if the raw import (with relative
       // segments resolved) matches an allowed pattern

diff --git a/tests/files/node_modules/@org/package/index.js b/tests/files/node_modules/@org/package/index.js
diff --git a/tests/files/node_modules/@org/package/internal.js b/tests/files/node_modules/@org/package/internal.js
diff --git a/tests/src/rules/no-internal-modules.js b/tests/src/rules/no-internal-modules.js
@@ -32,6 +32,10 @@ ruleTester.run('no-internal-modules', rule, {
       code: 'import get from "lodash.get"',
       filename: testFilePath('./internal-modules/plugins/plugin2/index.js'),
     }),
+    test({
+      code: 'import b from "@org/package"',
+      filename: testFilePath('./internal-modules/plugins/plugin2/internal.js'),
+    }),
     test({
       code: 'import b from "../../api/service"',
       filename: testFilePath('./internal-modules/plugins/plugin2/internal.js'),
@@ -100,6 +104,17 @@ ruleTester.run('no-internal-modules', rule, {
         },
       ],
     }),
+    test({
+      code: 'import b from "@org/package/internal"',
+      filename: testFilePath('./internal-modules/plugins/plugin2/internal.js'),
+      errors: [
+        {
+          message: 'Reaching to "@org/package/internal" is not allowed.',
+          line: 1,
+          column: 15,
+        },
+      ],
+    }),
     test({
       code: 'import get from "debug/node"',
       filename: testFilePath('./internal-modules/plugins/plugin.js'),