Add rules that show corner cases for commonJS

import-js · Mar 25, 2019 · be4f1c7 · be4f1c7
1 parent 206d676
commit be4f1c7
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/tests/src/rules/no-commonjs.js b/tests/src/rules/no-commonjs.js
@@ -39,6 +39,17 @@ ruleTester.run('no-commonjs', require('rules/no-commonjs'), {
     { code: 'var zero = require(0);' },
     { code: 'require("x")', options: [{ allowRequire: true }] },
 
+    // commonJS doesn't care how the path is built. You can use a function to
+    // dynamically build the module path.t st
+    { code: 'require(rootRequire("x"))', options: [{ allowRequire: true }] },
+    { code: 'require(String("x"))', options: [{ allowRequire: true }] },
+    { code: 'require(["x", "y", "z"].join("/"))', options: [{ allowRequire: true }] },
+
+    // commonJS rules should be scoped to commonJS spec. `rootRequire` is not
+    // recognized by this commonJS plugin.
+    { code: 'rootRequire("x")', options: [{ allowRequire: true }] },
+    { code: 'rootRequire("x")', options: [{ allowRequire: false}] },
+
     { code: 'module.exports = function () {}', options: ['allow-primitive-modules'] },
     { code: 'module.exports = function () {}', options: [{ allowPrimitiveModules: true }] },
     { code: 'module.exports = "foo"', options: ['allow-primitive-modules'] },