Webpack resolver plugin (#377)

* Add webpack.ResolverPlugin support

* Add tests

* Fix tests

resolvers/webpack/index.js

@@ -86,9 +86,19 @@ exports.resolve = function (source, file, settings) {
   // externals
   if (findExternal(source, webpackConfig.externals, path.dirname(file))) return { found: true, path: null }
 
+  var otherPlugins = []
+
+  // support webpack.ResolverPlugin
+  if (webpackConfig.plugins) {
+    webpackConfig.plugins.forEach(function (plugin) {
+      if (plugin.constructor && plugin.constructor.name === 'ResolverPlugin' && Array.isArray(plugin.plugins)) {
+        otherPlugins.push.apply(otherPlugins, plugin.plugins);
+      }
+    });
+  }
 
   // otherwise, resolve "normally"
-  var resolver = createResolver(webpackConfig.resolve || {})
+  var resolver = createResolver(webpackConfig.resolve || {}, otherPlugins)
   try {
     return { found: true, path: resolver.resolveSync(path.dirname(file), source) }
   } catch (err) {
@@ -116,7 +126,7 @@ var DirectoryDescriptionFileFieldAliasPlugin =
 
 // adapted from tests &
 // https://github.com/webpack/webpack/blob/v1.13.0/lib/WebpackOptionsApply.js#L322
-function createResolver(resolve) {
+function createResolver(resolve, otherPlugins) {
   var resolver = new Resolver(syncFS)
 
   resolver.apply(
@@ -135,6 +145,8 @@ function createResolver(resolve) {
     new ResultSymlinkPlugin()
   )
 
+  resolver.apply.apply(resolver, otherPlugins);
+
   return resolver
 }
 

resolvers/webpack/test/files/webpack.config.js

@@ -1,9 +1,11 @@
 var path = require('path')
+var pluginsTest = require('webpack-resolver-plugin-test')
 
 module.exports = {
   resolve: {
     alias: {
       'foo': path.join(__dirname, 'some', 'goofy', 'path', 'foo.js'),
+      'some-alias': path.join(__dirname, 'some')
     },
     modulesDirectories: ['node_modules', 'bower_components'],
     root: path.join(__dirname, 'src'),
@@ -20,4 +22,13 @@ module.exports = {
       callback();
     }
   ],
+
+  plugins: [
+    new pluginsTest.ResolverPlugin([
+      new pluginsTest.SimpleResolver(
+        path.join(__dirname, 'some', 'bar', 'bar.js'),
+        path.join(__dirname, 'some', 'bar')
+      )
+    ])
+  ]
 }

resolvers/webpack/test/plugins.js

@@ -0,0 +1,29 @@
+var chai = require('chai')
+  , expect = chai.expect
+  , path = require('path')
+
+var webpack = require('../index')
+
+var file = path.join(__dirname, 'files', 'dummy.js')
+
+describe("plugins", function () {
+  var resolved, aliasResolved
+
+  before(function () {
+    resolved = webpack.resolve('./some/bar', file)
+    aliasResolved = webpack.resolve('some-alias/bar', file)
+  })
+
+  it("work", function () {
+    expect(resolved).to.have.property('found', true)
+  })
+
+  it("is correct", function () {
+    expect(resolved).to.have.property('path')
+      .and.equal(path.join(__dirname, 'files', 'some', 'bar', 'bar.js'))
+  })
+
+  it("work with alias", function () {
+    expect(aliasResolved).to.have.property('found', true)
+  })
+})