Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6-only #20

Closed
benmosher opened this issue Mar 31, 2015 · 0 comments
Closed

es6-only #20

benmosher opened this issue Mar 31, 2015 · 0 comments

Comments

@benmosher
Copy link
Member

no-common => es6-only? or add no-amd?

no-common won't detect AMD modules... should the arms race of specific non-ES6 module types continue (more come to mind) or should it be retooled to report all import statements with specifiers* that point to a resolved module without ES6 syntax?

A thought: this would probably be cheaper to implement, as export syntax may only be present in the root scope. Would not need to traverse any deeper than the body, which means estraverse goes away and an empty ExportsMap is the harbinger of this report.

Also removes the need for "es6-only" as a setting for any rules.

I think I've sold myself on es6-only as a first-class rule, and dropping no-common + rule-specific measures.

  • note: this implicitly precludes imports such as import 'module'. Which makes sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant