Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition for rule 'import/no-reassign' was not found. #40

Closed
doctyper opened this issue Jul 22, 2015 · 2 comments
Closed

Definition for rule 'import/no-reassign' was not found. #40

doctyper opened this issue Jul 22, 2015 · 2 comments

Comments

@doctyper
Copy link

I'm getting an error using 0.7.4:

node_modules/eslint/lib/eslint.js:650
                    throw new Error("Definition for rule '" + key + "' was not
                          ^
Error: Definition for rule 'import/no-reassign' was not found.
    at node_modules/eslint/lib/eslint.js:650:27
@benmosher
Copy link
Member

Ah, interesting. I end-of-life'd no-reassign as it was mostly redundant with the core ESLint no-shadow and no-redeclare rules--it was originally created when there were gaps in escope's module handling and that was not the case--and moved the one novel bit into import/namespace.

I didn't realize it would be a breaking change. (though I have just realized I forgot to update the docs...)

I suspect you have the warning level set explicitly in your .eslintrc?

Not sure what to do as 0.7.4 fixes a different crash... I suppose for dogmatic semver observance I should put a dummyno-reassign back in, push 0.7.5, update docs, and push 0.8.0.

@benmosher
Copy link
Member

Just pushed 0.7.5 with updated docs. In my local test, the dummy rule seems to fix it.

I will wait on 0.8.0 to another day, but I would recommend pulling that rule from your config to avoid breaking then. 😅

2Pacalypse- added a commit to ShieldBattery/ShieldBattery that referenced this issue Nov 26, 2015
Also removes the import/no-reassign rule as per:
import-js/eslint-plugin-import#40
2Pacalypse- added a commit to ShieldBattery/ShieldBattery that referenced this issue Nov 26, 2015
Also removes the import/no-reassign rule as per:
import-js/eslint-plugin-import#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants