Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-mutable-exports fails when exporting types (flow) #758

Closed
Erid opened this issue Mar 1, 2017 · 5 comments
Closed

no-mutable-exports fails when exporting types (flow) #758

Erid opened this issue Mar 1, 2017 · 5 comments
Labels

Comments

@Erid
Copy link

Erid commented Mar 1, 2017

I was trying to do an export like the following:

export type { Options }

Having that on the file would throw the following exception:
image

By just removing that rule I was able to make it keep working, I think it would be nice for this plugin to also support flow (or not crash because of it).

@ljharb
Copy link
Member

ljharb commented Mar 1, 2017

Sure, that'd be great - a PR with a test case would be very helpful :-)

hazeledmands pushed a commit to hazeledmands/eslint-plugin-import that referenced this issue May 17, 2017
This tests the bug reported in issue import-js#758, which was actually already fixed in
PR import-js#660.
@hazeledmands
Copy link

hazeledmands commented May 17, 2017

@ljharb, @benmosher -- I was running into this issue, and wrote a test case, and then was very confused when I couldn't get it to fail.... until I looked closer and realized that the bug had already been fixed in master! (See my PR #835 for a test, and #660 for the code that fixed the test.)

Any chance you could push out a new bugfix version for this? Thanks!!

@ljharb
Copy link
Member

ljharb commented May 17, 2017

If the fix was done in November, why was this issue posted in March?

@Erid
Copy link
Author

Erid commented May 18, 2017

I believe the latest version published on NPM is from November 7 (2.2.0 at baa6b8a) and the commit that fixes this was made on November 14. My finding was based only on the published version.

@ljharb
Copy link
Member

ljharb commented May 18, 2017

ah, gotcha. looks like we're overdue for a release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants