New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-require: only report at top-level scope #88

Closed

2 tasks

benmosher opened this issue Nov 5, 2015 · 1 comment · Fixed by #96

Closed

2 tasks

no-require: only report at top-level scope #88

benmosher opened this issue Nov 5, 2015 · 1 comment · Fixed by #96

Milestone

Member

benmosher commented Nov 5, 2015

only report at top-level scope
Not possible import in deep scopes. Need to verify parent (naked require) or grandparent (via an assignment expression) is the program body.
don't report on paths ignored by import/ignore

The text was updated successfully, but these errors were encountered:

benmosher added this to the 0.10.0 milestone

benmosher added a commit that referenced this issue


          initial (failing) tests for #88

f8b557e

benmosher mentioned this issue

Merged

Member Author

benmosher commented Nov 9, 2015

Just kidding. Decided to just let this rule flag everything and turn it off if not trying to get rid of all requires.

benmosher added a commit that referenced this issue


          Simplified no-require. Close #88.

9a19d1d

benmosher closed this as completed in #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment