Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support export declarations in extensions rule #1012

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Support export declarations in extensions rule #1012

merged 1 commit into from
Feb 6, 2018

Conversation

silvenon
Copy link
Contributor

@silvenon silvenon commented Feb 2, 2018

Fixes #964.

@coveralls
Copy link

coveralls commented Feb 2, 2018 •
edited

Coverage Status

Coverage increased (+0.002%) to 96.226% when pulling ab49972 on silvenon:extensions-export into 3268a82 on benmosher:master.

ljharb
ljharb requested changes Feb 5, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you also add some tests for "never"?

@silvenon
Copy link
Contributor Author

silvenon commented Feb 6, 2018

Done.

The reason I was minimalistic with testing this is because IMO the import tests verify export tests because they use the same code, so I only need to test whether different kinds of export statements pass most basic tests.

@ljharb ljharb added the bug label Feb 6, 2018
@ljharb ljharb merged commit 219a8d2 into import-js:master Feb 6, 2018
@renovate renovate bot mentioned this pull request Feb 22, 2018
Merged
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silvenon @coveralls @ljharb