no-duplicates: add a query-string option to handle false positives wh… #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se positives when using some webpack loaders. Fixes import-js#1107.
ljharb
requested changes
May 28, 2018
docs/rules/no-duplicates.md
Outdated
| @@ -35,6 +35,31 @@ The motivation is that this is likely a result of two developers importing diffe | |||
| names from the same module at different times (and potentially largely different | |||
| locations in the file.) This rule brings both (or n-many) to attention. | |||
|
|
|||
| ### Query Strings | |||
|
|
|||
| By default, this rule ignores query strings (i.e. paths followed by a question mark), and thus imports from `./mod?a` and `./mod?b` will be considered as duplicates. However you can use the option `query-string` to handle them as different (usually because a webpack loader would actually resolve those imports differently). | |||
There was a problem hiding this comment.
primarily because browsers will resolve them differently; a webpack loader is secondary.
|
Schema added to the rule. I had the impression that several options could be offered, but let's keep it simple for now as I don't have any immediate usecase. |
ljharb
approved these changes
Jun 13, 2018
|
@benmosher @jfmengels can I get a review please? |
pcorpet
force-pushed
the
master
branch
3 times, most recently
from
0328e99
to
7aa4ce2
Compare
|
@ljharb what do we need to do to get this pull request merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en using some webpack loaders. Fixes #1107.