Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] order: Fix alphabetize for mixed requires and imports #1626

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

wschurman
Copy link
Contributor

Fixes #1625

Overview

The ranks of require items (which are +100) were being lost due to the algorithm not using the group rank when recalculating the alphabetized ranks.

To fix this, make the alphabetized rank of the item the group rank plus the alphabetization rank.

Test Plan

Run new unit tests. Before the change the tests would fail. After the change the tests pass.

@coveralls
Copy link

coveralls commented Jan 24, 2020

Coverage Status

Coverage remained the same at 97.838% when pulling 5d00854 on wschurman:fix-alphabetize into bbd166b on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.837% when pulling 29ad3bb on wschurman:fix-alphabetize into 99647f1 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.837% when pulling 29ad3bb on wschurman:fix-alphabetize into 99647f1 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.837% when pulling 29ad3bb on wschurman:fix-alphabetize into 99647f1 on benmosher:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[import/order] Alphabetization breaks ordering of require statements
3 participants