[Fix] order: fix isExternalModule detect on windows

[fisker]

isExternalModule is not right, when use \ as separator.

This cause external module detected as internal.

Seems we are not running test on windows. I add a test on isExternalModule

Fixes #1655

[coveralls]

Coverage increased (+0.001%) to 97.839% when pulling 47f912e on fisker:fix-order into 2beec94 on benmosher:master.

[coveralls]

Coverage increased (+0.001%) to 97.839% when pulling e720ca8 on fisker:fix-order into 45f0860 on benmosher:master.

[coveralls]

Coverage increased (+0.001%) to 97.839% when pulling e720ca8 on fisker:fix-order into 45f0860 on benmosher:master.

[coveralls]

Coverage increased (+0.001%) to 97.839% when pulling e720ca8 on fisker:fix-order into 45f0860 on benmosher:master.

[ljharb]

perhaps instead of handling both cases, we should use path.sep, so that it handles file paths according to the filesystem you're on?

[fisker]

I'm not sure that if path.sep works, but I guess no harm we just simply normalize the path?

[ljharb]

in that case, would node's path.normalize work?

[fisker]

I don't think path.normalize works like expected

require('path').normalize('E:/path\\to/')
'E:\\path\\to\\'

[ljharb]

(windows tests are broken pending #1648)

[ljharb]

Rebased this on top of #1648; still 1 test failing.

[fisker]

Should be good now.

[fisker]

@ljharb I fixed the failed test. But seems still breaking on Node.js@10. But local test passed on my laptop.... This has to be something related to require.resolve bug on Node.js@10, I'll figure.

[raphinesse]

@fisker The failures on Node 10 are due to the same problem with nyc that we did work around for in #1648 for Node 12 only.

[fisker]

@raphinesse

The error info shows require error

If we use that code for node.js 10, will it work?

[raphinesse]

@fisker I'm trying right now: 9e89605

[fisker]

@raphinesse If that's a bug from nyc, why not disable coverage on windows? Should be simplier

[raphinesse]

@raphinesse If that's a bug from nyc, why not disable coverage on windows? Should be simplier

@fisker I suggested that in #1648 (comment) but that comment got no reply from @ljharb. So I cannot tell you why.

[fisker]

@raphinesse You're right, problem solved. Thanks

[raphinesse]

@fisker The problem remains on Node 8. I've updated #1648 to use npm@6.10.3 for all Node versions. We'll see if that works for Node 8 too.

[ljharb]

I have no interest in disabling coverage anywhere; anything that disables coverage on windows is a nonstarter.

[fisker]

@raphinesse Have you try c8 on windows? Maybe that works.

[raphinesse]

@fisker Sorry, I don't have time to do so right now. Plus I fear it might not support enough Node/npm versions. That's just speculation though.

[fisker]

@raphinesse @ljharb Seems windows tests fixed now.

[ljharb]

Thanks! We're almost there :-)

[ljharb]

it doesn't seem like we're testing external-module-folders here if it was true before? meaning, maybe we need to add a test that returns false without external-module-folders, and true with it?

[fisker]

No, without external-module-folders still true, because subpath defualts to node_modules, the test make sure we need replace subpath, remove that line will cause error

[ljharb]

Sorry, to clarify; I'm glad these tests fail without your fix! However, don't we want to also test that a windows path would not be external without the right external-module-folders setting?

[ljharb]

i'm hoping for "false before, true after", not "same before and after". Can we come up with an example where the external-module-folders setting changes the result?

[fisker]

I'm not sure I understand this.

Setting import/external-module-folders did not change the result.

    expect(isExternalModule('foo', {
      'import/external-module-folders': ['E:\\path\\to\\node_modules'],
    }, 'E:\\path\\to\\node_modules\\foo')).to.equal(true)

    expect(isExternalModule('foo', {
    }, 'E:\\path\\to\\node_modules\\foo')).to.equal(true)

There are all true, and should be true, but before I add subpath.replace(/\\/g, '/'), this is false on windows, because it's bug. How do I test that, if you want reproduction, you just remove this fix, and

    expect(isExternalModule('foo', {
      'import/external-module-folders': ['E:\\path\\to\\node_modules'],
    }, 'E:\\path\\to\\node_modules\\foo')).to.equal(true)

this will fail.

[ljharb]

sure - i appreciate that the bug is that you get true, false instead of true, true.

However, to prevent different regressions later, i'm hoping to also have a test that correctly ensures false, true, even if that test would pass on master now :-)

[ljharb]

I went ahead and added something like that.