Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[flow] no-unused-modules: add flow type support" #1770

merged 1 commit into from May 19, 2020


Copy link

@Hypnosphi Hypnosphi commented May 19, 2020

#1542 was intended to fix issue #1540 but introduced a more critical issue, #1564. In my case, it blocks upgrading to the latest version with all the fancy features like alphabetical sorting.

This PR just reverts it

Fixes #1564. Reopens #1540.

Copy link

coveralls commented May 19, 2020

Coverage Status

Coverage decreased (-0.001%) to 97.738% when pulling 3f46ccf on Hypnosphi:revert-flow-types into 92caa35 on benmosher:master.

@ljharb ljharb merged commit 3f46ccf into import-js:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

no-unused-modules does not work properly with flow types exports
3 participants