[Fix] no-restricted-paths
: enhance performance for exceptions
#2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Move exceptions paths resolution and validation to rule create phase.
Background
There was a performance downgrade if
zone
hadexcept
option defined. On every import every relative exception path had to be resolved to absolute path and validated. See a corresponding issue #1758Results
On our SPA we have a lot of zones with exceptions. It turned out that this simple change gives us almost 10 times better performance. Measured with
TIMING=1 eslint
on our project.Before:
After: