Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] order: Fix import ordering in TypeScript module declarations #2226

Merged

Conversation

@remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Sep 12, 2021

Without this, import/order checks if all imports in a file are sorted. The autofix would then move all imports to the type of the file, breaking TypeScript module declarations.

Closes #2217

Without this, `import/order` checks if all imports in a file are sorted. The
autofix would then move all imports to the type of the file, breaking TypeScript
module declarations.

Closes import-js#2217
@codecov
Copy link

@codecov codecov bot commented Sep 12, 2021

Codecov Report

Merging #2226 (7f25ace) into main (4ed7867) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Current head 7f25ace differs from pull request most recent head 47ea669. Consider uploading reports for the commit 47ea669 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
+ Coverage   84.04%   84.29%   +0.24%     
==========================================
  Files          96       93       -3     
  Lines        3034     2979      -55     
  Branches      900      882      -18     
==========================================
- Hits         2550     2511      -39     
+ Misses        484      468      -16     
Impacted Files Coverage Δ
src/rules/order.js 99.06% <100.00%> (-0.30%) ⬇️
src/ExportMap.js 92.85% <0.00%> (ø)
config/typescript.js 100.00% <0.00%> (ø)
utils/unambiguous.js 100.00% <0.00%> (ø)
src/rules/no-unresolved.js 100.00% <0.00%> (ø)
utils/visit.js
utils/pkgUp.js
utils/readPkgUp.js
src/rules/no-unused-modules.js 99.76% <0.00%> (+2.32%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed7867...47ea669. Read the comment docs.

Loading

ljharb
ljharb approved these changes Sep 18, 2021
Copy link
Collaborator

@ljharb ljharb left a comment

Seems great!

Loading

src/rules/order.js Outdated Show resolved Hide resolved
Loading
@ljharb ljharb force-pushed the fix-order-typescript-module-declarations branch from 7f25ace to 47ea669 Sep 18, 2021
@ljharb ljharb changed the title [fix] order: Fix import ordering in TypeScript module declarations [Fix] order: Fix import ordering in TypeScript module declarations Sep 18, 2021
@ljharb ljharb merged commit 47ea669 into import-js:main Sep 18, 2021
95 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants