-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate identifiers in duplicate imports #2577
Conversation
Closing and resubmitting with my personal account 😅 |
oof, duplicate PRs never go away :-/ can this be reopened so i can keep the two PRs in sync? |
Sorry about that. Edit: actually I'll just keep this one open in lieu of submitting another, it's not a big deal. |
If you want, I can rewrite the commit so it comes from your personal account :-) (github keeps a "ref" for every PR that's ever been opened, that isn't fetched by default, although i fetch them all. as such, closing a PR leaves an orphaned ref, and it makes my git log harder to understand) |
d9ca6a2
to
2b41e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joe-matsec sorry for the late review! I rebased this, and a bunch of tests are failing. It's entirely possible that my attempt to conflict resolve has caused the problem - can you take a look?
We may also need to add some more test cases for duplicate inline type
imports.
51619a6
to
cec3652
Compare
@ljharb I think this is ready for another review when you have some time! |
cec3652
to
1927d60
Compare
@ljharb I rebased again and it looks like CI is still good, if you have some time to review. Thanks! |
1927d60
to
50b3d23
Compare
Resolves #2437.
This PR deduplicates import identifiers!