Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate identifiers in duplicate imports #2577

Merged
merged 1 commit into from Feb 7, 2023

Conversation

joe-matsec
Copy link

Resolves #2437.

This PR deduplicates import identifiers!

@joe-matsec
Copy link
Author

Closing and resubmitting with my personal account 😅

@joe-matsec joe-matsec closed this Oct 21, 2022
@ljharb
Copy link
Member

ljharb commented Oct 21, 2022

oof, duplicate PRs never go away :-/ can this be reopened so i can keep the two PRs in sync?

@joe-matsec
Copy link
Author

joe-matsec commented Oct 21, 2022

Sorry about that.
Not sure I understand the idea behind keeping them both open but sure I can do that.

Edit: actually I'll just keep this one open in lieu of submitting another, it's not a big deal.

@joe-matsec joe-matsec reopened this Oct 21, 2022
@ljharb
Copy link
Member

ljharb commented Oct 21, 2022

If you want, I can rewrite the commit so it comes from your personal account :-)

(github keeps a "ref" for every PR that's ever been opened, that isn't fetched by default, although i fetch them all. as such, closing a PR leaves an orphaned ref, and it makes my git log harder to understand)

src/rules/no-duplicates.js Outdated Show resolved Hide resolved
src/rules/no-duplicates.js Outdated Show resolved Hide resolved
tests/src/rules/no-duplicates.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the deduplicate-import-identifiers branch from d9ca6a2 to 2b41e42 Compare January 11, 2023 07:25
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joe-matsec sorry for the late review! I rebased this, and a bunch of tests are failing. It's entirely possible that my attempt to conflict resolve has caused the problem - can you take a look?

We may also need to add some more test cases for duplicate inline type imports.

@ljharb ljharb marked this pull request as draft January 11, 2023 17:10
@jportner jportner force-pushed the deduplicate-import-identifiers branch 2 times, most recently from 51619a6 to cec3652 Compare January 23, 2023 20:00
@joe-matsec
Copy link
Author

@ljharb I think this is ready for another review when you have some time!
I'm not sure how to deal with Travis CI - Pull Request Action required after 4m — Build Errored but everything else is green in CI.

@joe-matsec joe-matsec marked this pull request as ready for review January 23, 2023 20:54
@jportner jportner force-pushed the deduplicate-import-identifiers branch from cec3652 to 1927d60 Compare February 3, 2023 20:53
@joe-matsec
Copy link
Author

@ljharb I rebased again and it looks like CI is still good, if you have some time to review. Thanks!

@ljharb ljharb force-pushed the deduplicate-import-identifiers branch from 1927d60 to 50b3d23 Compare February 3, 2023 22:22
@ljharb ljharb closed this Feb 7, 2023
@ljharb ljharb reopened this Feb 7, 2023
@ljharb ljharb merged commit 50b3d23 into import-js:main Feb 7, 2023
301 of 302 checks passed
@joe-matsec joe-matsec deleted the deduplicate-import-identifiers branch May 8, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicates names in no-duplicates autofix
3 participants