Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable quotes rule for eslint #280

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Enable quotes rule for eslint #280

merged 1 commit into from
Apr 27, 2016

Conversation

singles
Copy link
Contributor

@singles singles commented Apr 27, 2016 •
edited
Loading

I missed those quotes while doing other PR: #245 (comment) :)

Now it should be harder to miss that :)

@singles singles mentioned this pull request Apr 27, 2016
Closed
@jfmengels
Copy link
Collaborator

LGTM :)
@benmosher is this something you didn't want to enforce by any chance?

@benmosher
Copy link
Member

I just recently turned it off, actually. This is one of those rules that (from my perspective) is as controversial as it is arbitrary.

Which is to say: fine with me to turn it back on. 😁

@jfmengels
Copy link
Collaborator

Let's merge this then?

@benmosher
Copy link
Member

👍

@benmosher benmosher merged commit 082e5b3 into import-js:master Apr 27, 2016
@singles singles deleted the enable-single-quotes-rule branch April 27, 2016 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@singles @jfmengels @benmosher