New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslints #2871

Closed

OlivierZal wants to merge 1 commit into import-js:main from OlivierZal:olivierzal/fix_eslints

OlivierZal commented Sep 1, 2023

@ljharb, to make tests more readable...


          Fix eslints

8f3e08b

Member

ljharb commented Sep 2, 2023

is there anything enforcing this?

Author

OlivierZal commented Sep 2, 2023

Not really, I just read the test results from my other PR.

Member

ljharb commented Sep 2, 2023

These formatting changes should be enforced with eslint rules if we're going to make them en masse.

Author

OlivierZal commented Sep 2, 2023

I fixed all the warnings I saw there: https://github.com/import-js/eslint-plugin-import/actions/runs/6049563566/job/16417081560#step:4:1 (except the no-console one).

OlivierZal closed this

OlivierZal deleted the olivierzal/fix_eslints branch

September 2, 2023 11:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment