Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] dynamic-import-chunkname: add allowEmpty option to allow empty leading comments #2942

Merged

Conversation

JiangWeixian
Copy link
Contributor

@JiangWeixian JiangWeixian commented Dec 17, 2023

Closes: #2941

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty good.

docs/rules/dynamic-import-chunkname.md Outdated Show resolved Hide resolved
@ljharb ljharb changed the title feat: allow empty leading comments [New] dynamic-import-chunkname: add allowEmpty option to allow empty leading comments Dec 17, 2023
@JiangWeixian JiangWeixian marked this pull request as ready for review December 17, 2023 06:35
@JiangWeixian
Copy link
Contributor Author

@ljharb Can we merge this pr

@ljharb ljharb force-pushed the fix/issue-2941-allow-empty-chunk-name branch from a0d5ba5 to e9489d8 Compare December 29, 2023 06:57
@ljharb ljharb merged commit e9489d8 into import-js:main Dec 29, 2023
175 of 176 checks passed
ljharb added a commit that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

support check chunk-name format only in dynamic-import-chunkname rule
2 participants