Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) #2987

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

joeyguerra
Copy link
Contributor

Converting the appveyor pipeline to GitHub Actions.

.eslintrc Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.nycrc Outdated Show resolved Hide resolved
tests/src/core/resolve.js Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.eslintrc Outdated Show resolved Hide resolved
@joeyguerra
Copy link
Contributor Author

I've confirmed that separate runs using Vampire/setup-wsl are disconnected in that you can't use npm in one run when Node is installed in another one. In addition, nvm is unavailable in a run when using ljharb/actions/node/install in a previous run. Thus necessitating the whole script be done in 1 run for the WSL configuration.

I've also taken a different strategy to address the other problems (typically unexpected token errors). Which results in passing tests without having to ignore checks in the utils/ code.

@ljharb would you mind taking another look at this PR?

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, if the tests pass then I'm happy with this approach - I can consolidate things into reusable scripts later :-)

.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Outdated Show resolved Hide resolved
.github/workflows/native-wsl.yml Show resolved Hide resolved
@ljharb ljharb changed the title chore: Run tests on Windows in both pwsh and WSL (Ubuntu) [Tests] appveyor -> GHA (run tests on Windows in both pwsh and WSL + Ubuntu) Mar 22, 2024
@ljharb ljharb merged commit fa60e3d into import-js:main Mar 22, 2024
192 of 193 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants