-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump minimum node version to 16 #3008
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely not. This would be a breaking change, and platform support has zero bearing whatsoever on what node versions a library should support.
Thanks for the feedback. What node versions must still be supported by this project and why? |
We support down to eslint 2, and we support down to node 4 (arguably we should support down to node 0.10, but we haven't prioritized that and nobody's asked for it) Additionally, breaking changes are the most costly thing any package can impose on the ecosystem, and "dropping a node version" has a very small amount of benefit, so there'd need to be actually good reasons to do a breaking change before dropping a node version happened. |
eslint-plugin-import declares support for extremely broad versions of node. Updated to remove support for out-of-support node versions (node 16 is the oldest currently supported version, reaching end of life next month)