Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimum node version to 16 #3008

Closed
wants to merge 1 commit into from
Closed

Conversation

rotu
Copy link

@rotu rotu commented May 20, 2024

eslint-plugin-import declares support for extremely broad versions of node. Updated to remove support for out-of-support node versions (node 16 is the oldest currently supported version, reaching end of life next month)

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@angular-eslint/template-parser@13.5.0 None +4 1.05 MB jameshenry
npm/@typescript-eslint/parser@5.62.0 Transitive: environment, filesystem +31 2.53 MB jameshenry
npm/babel-cli@6.26.0 Transitive: environment, eval, filesystem, shell +140 7.34 MB hzoo
npm/babel-eslint@10.1.0 Transitive: environment, filesystem +35 6.42 MB kaicataldo
npm/babel-plugin-module-resolver@2.7.1 filesystem Transitive: environment +3 189 kB tleunen
npm/babel-preset-airbnb@2.6.0 Transitive: environment, eval, filesystem +103 7.74 MB lencioni
npm/babel-preset-flow@6.23.0 Transitive: environment, eval, filesystem +5 2.34 MB loganfsmyth
npm/chai@4.4.1 None +7 923 kB keithamus
npm/cross-env@4.0.0 environment Transitive: filesystem, shell +9 109 kB kentcdodds
npm/eslint-doc-generator@1.7.1 Transitive: environment, eval, filesystem, shell, unsafe +87 7.76 MB bmishkin
npm/eslint-import-resolver-typescript@1.1.1 Transitive: environment, filesystem +4 170 kB bradzacher
npm/eslint-plugin-eslint-plugin@2.3.0 filesystem 0 105 kB not-an-aardvark
npm/eslint-plugin-json@2.1.2 Transitive: environment, filesystem +6 2.35 MB abandeali
npm/find-babel-config@=1.2.0 None 0 13.8 kB tleunen
npm/fs-copy-file-sync@1.1.1 filesystem 0 8.57 kB coderaiser
npm/in-publish@2.0.1 None 0 4.01 kB iarna
npm/jackspeak@=2.1.1 None 0 210 kB isaacs
npm/jsonc-parser@=3.2.0 None 0 205 kB alexandrudima, joaomoreno.ms, kaimaetzel, ...4 more
npm/linklocal@2.8.2 filesystem Transitive: shell +6 341 kB timoxley
npm/markdownlint-cli@0.35.0 Transitive: environment, filesystem, shell +29 4.95 MB davidanson
npm/npm-which@3.0.1 environment Transitive: filesystem, shell +4 137 kB timoxley
npm/nyc@15.1.0 environment, filesystem, unsafe Transitive: eval, shell +131 14.1 MB coreyfarrell
npm/redux@3.7.2 environment Transitive: eval +5 2.21 MB timdorr
npm/rimraf@2.7.1 filesystem 0 15.5 kB isaacs
npm/safe-publish-latest@2.0.0 environment, shell Transitive: filesystem +13 603 kB ljharb
npm/sinon@2.4.1 None +9 7.58 MB mrgnrdrck
npm/typescript-eslint-parser@22.0.0 None +6 476 kB eslint
npm/typescript@4.5.5 None 0 64 MB typescript-bot

🚮 Removed packages: npm/array.prototype.find@2.2.3, npm/chai@3.5.0, npm/enhanced-resolve@0.9.1, npm/eslint-import-resolver-webpack@0.13.8, npm/eslint@9.3.0, npm/find-root@1.1.0, npm/interpret@1.4.0, npm/nyc@11.9.0, npm/react@16.14.0, npm/resolve@2.0.0-next.5, npm/webpack@5.91.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/fsevents@1.2.13
  • Install script: install
  • Source: node install.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/fsevents@1.2.13

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not. This would be a breaking change, and platform support has zero bearing whatsoever on what node versions a library should support.

@ljharb ljharb closed this May 20, 2024
@rotu
Copy link
Author

rotu commented May 20, 2024

Absolutely not. This would be a breaking change, and platform support has zero bearing whatsoever on what node versions a library should support.

Thanks for the feedback. What node versions must still be supported by this project and why?

@ljharb
Copy link
Member

ljharb commented May 21, 2024

We support down to eslint 2, and we support down to node 4 (arguably we should support down to node 0.10, but we haven't prioritized that and nobody's asked for it)

Additionally, breaking changes are the most costly thing any package can impose on the ecosystem, and "dropping a node version" has a very small amount of benefit, so there'd need to be actually good reasons to do a breaking change before dropping a node version happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants