no-extraneous-dependencies: add support/option for peerDependencies (#423)
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmengels
force-pushed
the
extraneous-allow-peer-dependencies
branch
2 times, most recently
from
15b37d6
to
2da02a7
Compare
|
Modified so that peerDependencies is true by default |
jfmengels
force-pushed
the
extraneous-allow-peer-dependencies
branch
from
445282d
to
08e2c2a
Compare
Because I like copy-pasting and didn't notice I copied too much 😄 Removed 👍 |
|
Good on your end? I'm ready to merge once |
|
All good for me if the tests pass 👍 |
|
coverage should bump back up once the OSX builds complete. also the failures on the Travis/push build are fixed in |
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-extraneous-dependencies: add support/option forpeerDependencies(#423)