Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #570: No newline after inline require #579

Merged
merged 2 commits into from
Sep 26, 2016

Conversation

jfmengels
Copy link
Collaborator

@jfmengels jfmengels commented Sep 23, 2016

Breaking change - newline-after-import: Do not require empty line after inline require (fixes #570).

cc @singles @sindresorhus

I made two commits:

  • One applying the change and making the new tests pass
  • One simplifying the implementation by removing the whole usage of scopes (redundant with the level system I picked from the order rule, and a bit more complex IMO)

@jfmengels jfmengels added this to the 2.0.0 milestone Sep 23, 2016
@jfmengels
Copy link
Collaborator Author

Rebased due to the merge of the v2 branch.

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage decreased (-0.2%) to 97.61% when pulling 821a02d on newline-after-import-require into e3c41ca on master.

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage decreased (-0.2%) to 97.61% when pulling b85b965 on newline-after-import-require into e3c41ca on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 97.61% when pulling b85b965 on newline-after-import-require into e3c41ca on master.

@benmosher
Copy link
Member

:shipit:

@benmosher benmosher merged commit 29e1874 into master Sep 26, 2016
@jfmengels jfmengels deleted the newline-after-import-require branch September 26, 2016 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

newline-after-import should not apply to inline require's
3 participants