chore(eslint): upgrade to eslint@4

[mastilver]

close #870

[coveralls]

Coverage remained the same at 95.157% when pulling 3f8bfdf on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

[coveralls]

Coverage remained the same at 95.157% when pulling 3f8bfdf on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

[coveralls]

Coverage remained the same at 95.157% when pulling 3f8bfdf on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

[corbinu]

peerDependencies also needs to be updated to allow for eslint 4

[coveralls]

Coverage remained the same at 95.157% when pulling f5dbba8 on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

[coveralls]

Coverage remained the same at 95.157% when pulling f5dbba8 on mastilver:upgrade-to-eslint-4 into 3c46d30 on benmosher:master.

[mastilver]

The failing tests are also failing on master, I will try to find what's going on

I would like to get some help to apply the same logic for appveyor as I did for travis! :)

[ShayDavidson]

Hey, any update on this? Thanks!

[Arcanemagus]

@mastilver For AppVeyor you will need to put each of the 6 combinations as individual groups in the environment matrix, so something like this:

environment:
  matrix:
    - nodejs_version: "7"
      ESLINT_VERSION: "4"

    - nodejs_version: "7"
      ESLINT_VERSION: "3"

    - nodejs_version: "7"
      ESLINT_VERSION: "2"

    - nodejs_version: "6"
      ESLINT_VERSION: "4"

    - nodejs_version: "6"
      ESLINT_VERSION: "3"

    - nodejs_version: "6"
      ESLINT_VERSION: "2"

Note also that it seems npm v3 is being forcibly installed for some reason, possibly an artifact from when Node.js v0.10 was still supported. As this is a downgrade for both of those versions of Node.js this should probably be removed unless it is still testing something relevant.

[ljharb]

npm 3 is absolutely still supported, as is npm 2, because that's what node 4 and 6 ship with.

That said, we shouldn't be forcibly installing an older version of npm.

[alexander-akait]

/cc @mastilver friendly ping

[mastilver]

@evilebottnawi Yeah, I know... :)

I need to allocate more time for it, I will continue tonight or Sunday
In the meantime if someone want to take over feel free or ping me and I'll add you to the fork

[coveralls]

Coverage remained the same at 95.157% when pulling 72472fd on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

[coveralls]

Coverage remained the same at 95.157% when pulling eec46df on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

[coveralls]

Coverage remained the same at 95.157% when pulling eec46df on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

[coveralls]

Coverage remained the same at 95.157% when pulling ca8c28b on mastilver:upgrade-to-eslint-4 into 3f9e4bf on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling c58fad7 on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[benmosher]

@mastilver

remove eslint matrix for appveyor and just keep the node matrix

sounds good to me 👍🏻

[Arcanemagus]

Looks like the failing Travis CI build is on a test that normally takes a while to run, as that specific job was the longest running is that an intermittent failure on the slower OS X hosts?

[coveralls]

Coverage remained the same at 95.963% when pulling 4c52e1a on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling 4c52e1a on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[mastilver]

@benmosher I think it would be handy to enable Auto cancel pull request builds on travis

[coveralls]

Coverage remained the same at 95.963% when pulling a8ca5bb on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[coveralls]

Coverage remained the same at 95.963% when pulling a8ca5bb on mastilver:upgrade-to-eslint-4 into 0263be4 on benmosher:master.

[benmosher]

Ah, neat. I didn't even know that was an option, thanks! And great work! 🎉🙏🏻🎉

[lukeapage]

@benmosher please can we have a new release to unblock using eslint 4?

[ljharb]

@lukeapage #870 (comment) please be patient. Using eslint 4 isn't urgent :-)

[lukeapage]

Sorry should have checked the issue, I thought it had just been forgotten.

[benmosher]

published 👍🏻