Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In redesign: Existing profile pictures may have wrong size #691

Open
imported-from-roundup opened this issue Aug 7, 2014 · 0 comments
Open

Comments

@imported-from-roundup
Copy link
Owner

Comment by paulproteus:

Right now, we rescale people's profile pictures to proportions that made sense
for the old layout.

The new layout has more space for profile pictures, so we need to adjust the
default proportions in the backend, as well as adjust the template to use the
new size, as well as make sure that existing personal profile images can be
easily re-scaled to the right size.

The re-scaling can happen "lazily" (at page load-time) or "eagerly" (we could
run a management command or something that does the rescaling).

(This bug is about the redesign of the site that is occurring during 0.12.02.
You can see that redesign in process, temporarily, here:
http://gentle-robot-6466.herokuapp.com/ )


Comment by paulproteus:

Marking as 'later' for now. Maybe something to look at during the sprint?


Comment by onceuponatimeforever:

Can you take a screenshot of the bug? Im not sure if this is still a reproducible bug.


Comment by mmilkin:

is this the same bug as when you go to the
http://openhatch.org/account/edit/photo/
the site has bad padding and wraps the box.


Comment by mmilkin:

Looks like there are some css issues in the photo page


Comment by mmilkin:


openhatch/oh-mainline#224


Comment by paulproteus:

oh my goodness yesssss


Comment by skfroi:

Disregard my last comment (msg4252). I confused this bug with
https://openhatch.org/bugs/issue956. I'll be posting the comment with the screenshot to that bug.
Sorry for the mix up.


Comment by mmilkin:

I also didn't want to effect more then that one page so what I did was
remved the fat and skinny from the class definitions and created a new
class that had the right width alignment (I hope it will work for you)
( what I suggest is move the class form mysite/static/css/profile/base.css to
some place more general)

+body div.photo-wide { width: 64%; }

  • Mike

On Thu, Apr 17, 2014 at 11:44 PM, skfroi <bugs@openhatch.org> wrote:

>
> skfroi <irizarry.froilan@gmail.com> added the comment:
>
> This same issue is found on the set location page (see attached img). I'm
> working on a way to fix
> this without affecting anything else. Up to know the fix would be to set
> the submodule.skinny css
> class to a margin of 15px, down from 20px, or to eliminate the border to
> the links box at the left.
>
> Any suggestions?
>
> ----------
> nosy: +skfroi
>
> __________________________________________
> Roundup issue tracker <bugs@openhatch.org>
> <https://openhatch.org/bugs/issue691>
> __________________________________________


File at http://roundup-archive.openhatch.org/bugs/file672/unnamed by mmilkin

Status: need-review
Nosy List: mmilkin, paulproteus, skfroi
Priority: bug
Imported from roundup ID: 691 (view archived page)
Last modified: 2014-04-18.12:51:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant