bug-691

[mmilkin]

Changed the css and the html and css of the edit_photo page

Major changes (removed fat and skinny classes) added a new class that fixes the width of the containers.

[paulproteus]

This looks good tentatively. I'm concerned that you may have added mismatched tags; @eeshangarg , is this something you can review at some point?

[eeshangarg]

I reviewed the diff and applied it to my local copy and tested it and it fixes the problems in the "Profile photo settings" http://openhatch.org/account/edit/photo/ page(screenshot of my profile photo page after applying the diff above locally is attached) but as we can see in the screenshot, the section with "Choose a photo" Browse... "No file selected" is not aligned correctly. I have already created a new issue about this in the OpenHatch issue tracker: https://openhatch.org/bugs/issue956. @mmilkin, is this something that you'd like to work on at some point?

[paulproteus]

@eeshangarg It's helpful if you can say:

+1

or something else indicating a positive review at the top, too.

I take your comments to indicate a positive review, so I will merge this. Thanks oodles for the review, as well as following up on the review by filing the issue!

[mmilkin]

yep I can prettify it. feel free to assign it to me.

[eeshangarg]

So, I assigned the issue 956 to you :
https://openhatch.org/bugs/issue956

And thanks for teaching me about git on the first day of the sprints.
Eeshan