-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event cancelling to chat messages #92
Comments
I don't think event cancelling should be limited to just chat events. Ideally all events would be cancellable. |
Due to how events work, this should be doable on every type of event. I think
The fourth step can be ignored if the event was canceled, and other players won't see the thing happen. |
Could this lead to possible desync? |
🤔 Probably on some events. |
@Mm2PL this will lead to desync, it will only work for specific type of events like chatting. For cancelling other events (such as venting) we would need to send the inverse of that event (going out of the vent). Because client's do not verify their action with the server before doing it. |
I've been messing around with blocking packets. |
@danbudworthmead I won't be merging that if you PR it. Reason for that is that there can be another GameData message after the GameData event you are canceling. You are returning, effectively canceling everything in that stream. |
Aha dw not planning to PR. Just thought it might be useful in this thread if someone's looking to do something similar. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Api Suggestion
Suggestion
As the ability to cancel events with the API
Use case
For my particular use case, I want to be able to cancel message events starting with
/
Expected result
Player Sends Message Starting With "/",
The Event Is Cancelled,
No player receives the message
(Message can still be sent with e.Game.SendToAsync())
The text was updated successfully, but these errors were encountered: