fix: format dates to WordPress date_format

[jr70]

User Story

As a Give Admin, I want the start/end date filter format in the Donations admin page to match my locale so that I have a consistent user experience.

My website has UK English (en_GB) as the site language so I expect all dates to be formatted as dd/mm/yyyy.

Current Behavior

Currently the date filter boxes have a placeholder of mm/dd/yyyy and when a date is selected from the dropdown calendar it is returned in the same US date format.

Expected Behavior

I expect to see dd/mm/yyyy as the placeholder and have the date returned from the calendar dropdown formatted to dd/mm/yyyy.

Acceptance Criteria

• The date picker supports all date format (US or non-US) based on WordPress date settings.
• Supporting WP date format does not affect other functionality like donation exports.

Related

https://secure.helpscout.net/conversation/671557137/26233
https://secure.helpscout.net/conversation/658188284/25003?folderId=672197

[kevinwhoffman]

@jr70 Thank you for the detailed issue. I've assigned @Sidsector9 to confirm the issue and work on a fix in an upcoming maintenance release of Give 2.2.1.

[raftaar1191]

Finding

We need to fix the date format at other places to

@ravinderk should I create a new issue for this or else will fix this in the current issue as well

[raftaar1191]

Closing this issue as after running npm run dev this issue was solved

[mathetos]

Reopening as we have a new customer reporting this same problem. To clarify, the original report was NOT about the Export functionality, but the Donations screen. This screen:

Steps to Replicate:

1. Go to "Settings > General"
2. For the "Date Format" setting, use j F, Y or some other non-U.S. date format
3. Navigate to "Donations > Donations" and attempt to use the Date Filter at the top of the donations table. It will not fill the fields correctly.

Customer reported here:
https://secure.helpscout.net/conversation/658188284/25003/
https://secure.helpscout.net/conversation/674590613/26494?folderId=672194

[kevinwhoffman]

@Sidsector9 I recently fixed a similar issue in WPBR https://github.com/WordImpress/wp-business-reviews/pull/259

I think it has to do with certain PHP date formats not being compatible with JS date formats.

[marutim]

Along with that, if the date format is set to dd/mm/yyyy, the export donations do not work at all. It alerts the admin with the following error

The fix should make sure that export functionality should work with all date formats.

More details about this issue in HS link: https://secure.helpscout.net/conversation/671557137/26233