New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format dates to WordPress date_format
#3502
Comments
@jr70 Thank you for the detailed issue. I've assigned @Sidsector9 to confirm the issue and work on a fix in an upcoming maintenance release of Give |
date_format
fix(i18n): format dates to WordPress `date_format` #3502
FindingWe need to fix the date format at other places to @ravinderk should I create a new issue for this or else will fix this in the current issue as well |
Closing this issue as after running |
Reopening as we have a new customer reporting this same problem. To clarify, the original report was NOT about the Export functionality, but the Donations screen. This screen: Steps to Replicate:
Customer reported here: |
@Sidsector9 I recently fixed a similar issue in WPBR https://github.com/WordImpress/wp-business-reviews/pull/259 I think it has to do with certain PHP date formats not being compatible with JS date formats. |
Along with that, if the date format is set to dd/mm/yyyy, the export donations do not work at all. It alerts the admin with the following error The fix should make sure that export functionality should work with all date formats. More details about this issue in HS link: https://secure.helpscout.net/conversation/671557137/26233 |
date_format
date_format
fix: format dates to WordPress `date_format` #3502
User Story
As a
Give Admin
, I want thestart/end date filter format
in the Donations admin page to match my locale so thatI have a consistent user experience
.My website has UK English (en_GB) as the site language so I expect all dates to be formatted as
dd/mm/yyyy
.Current Behavior
Currently the date filter boxes have a placeholder of
mm/dd/yyyy
and when a date is selected from the dropdown calendar it is returned in the same US date format.Expected Behavior
I expect to see
dd/mm/yyyy
as the placeholder and have the date returned from the calendar dropdown formatted todd/mm/yyyy
.Acceptance Criteria
Related
https://secure.helpscout.net/conversation/671557137/26233
https://secure.helpscout.net/conversation/658188284/25003?folderId=672197
The text was updated successfully, but these errors were encountered: