Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong global variable in give-ajax.js in latest version of plugin (2.2.4) #3684

Closed
codep0et opened this issue Sep 14, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@codep0et
Copy link

commented Sep 14, 2018

Current Behavior

When you try to login on a give form, you have an infinite loading that goes on because the global ajax url for the login is an object.

Expected Behavior

I expect to be logged in

Steps to Reproduce

  1. Go on a form donation page
  2. Try to log in

Acceptance Criteria

  • If you click login, the data gets submitted to the write ajax url

Simple fix is to change the function from Give.fn.getGlobal('ajaxurl') to Give.fn.getGlobalVar('ajaxurl') line 115 of give-ajax.js (https://github.com/WordImpress/Give/blob/release/2.3.0/assets/src/js/frontend/give-ajax.js#L115)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.