Add a second argument to the_title filter to prevent fatal error
#3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, there was an error when another plugin adds a 'the_title' filter that has 2 arguments, as this only passes 1 argument. So add the post ID to prevent this.
ravinderk
approved these changes
Dec 12, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents a fatal error
How Has This Been Tested?
Steps to reproduce
/wp-admin/post-new.php?post_type=give_forms/wp-admin> AMP > Template Mode, select "Paired," and click "Save Changes"With this PR, there's no error.
Background
The fatal error is reported for AMP_Validated_URL_Post_Type:: filter_the_title_in_post_list_table(), as that filters the_title.
It has 2 parameters, as the documentation for
the_titlerequires. But theapply_filters()call here only passes it 1 argument.Types of changes
Bug fix
Checklist:
For #3895