Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a second argument to the_title filter to prevent fatal error #3899

Merged
merged 2 commits into from Dec 12, 2018
Merged

Add a second argument to the_title filter to prevent fatal error #3899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74c46d8
Pass the post ID to the 'the_title' filter
kienstra Dec 11, 2018
a771132
Add inline documentation of filter
kienstra Dec 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion includes/admin/shortcodes/abstract-shortcode-generator.php
View file
Open in desktop
Expand Up @@ -298,7 +298,8 @@ protected function generate_post( $field ) {
foreach ( $posts as $post ) {
$options[ absint( $post->ID ) ] = empty( $post->post_title )
? sprintf( __( 'Untitled (#%s)', 'give' ), $post->ID )
: apply_filters( 'the_title', $post->post_title );
/** This filter is documented in wp-includes/post-template.php */
: apply_filters( 'the_title', $post->post_title, $post->ID );
}

$field['type'] = 'listbox';
Expand Down