Merge pull request #2547 from mehul0810/issue/2545

Issue/2545
impress-org · Dec 20, 2017 · 128dd3e · 128dd3e
2 parents 78bb7e6 + af1c2f5
commit 128dd3e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/includes/admin/shortcodes/class-shortcode-button.php b/includes/admin/shortcodes/class-shortcode-button.php
@@ -171,27 +171,27 @@ public function shortcode_button() {
 
 				reset( $shortcodes );
 
-				if ( count( $shortcodes ) == 1 ) {
+				if ( 1 === count( $shortcodes ) ) {
 
 					$shortcode = key( $shortcodes );
 
 					printf(
-						'<button class="button sc-shortcode" data-shortcode="%s">%s</button>',
+						'<button type="button" class="button sc-shortcode" data-shortcode="%s">%s</button>',
 						$shortcode,
 						sprintf( '%s %s %s',
 							$img,
-							esc_html__( 'Insert', 'give' ),
+							__( 'Insert', 'give' ),
 							self::$shortcodes[ $shortcode ]['label']
 						)
 					);
 				} else {
 					printf(
 						'<div class="sc-wrap">' .
-						'<button class="button sc-button">%s %s</button>' .
+						'<button class="button sc-button" type="button">%s %s</button>' .
 						'<div class="sc-menu mce-menu">%s</div>' .
 						'</div>',
 						$img,
-						esc_html__( 'Give Shortcodes', 'give' ),
+						__( 'Give Shortcodes', 'give' ),
 						implode( '', array_values( $shortcodes ) )
 					);
 				}