Merge pull request #858 from ramiy/release/1.7

a11y in give shortcode
impress-org · Aug 10, 2016 · 690c4d5 · 690c4d5
2 parents efeef30 + 7fc4c6d
commit 690c4d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/templates/shortcode-login.php b/templates/shortcode-login.php
@@ -22,8 +22,9 @@
 			?>
 			<div class="give-login-username give-login">
 				<label for="give_user_login"><?php esc_html_e( 'Username', 'give' ); ?></label>
-				<input name="give_user_login" id="give_user_login" class="give-required give-input" type="text" title="<?php esc_attr_e( 'Username', 'give' ); ?>" />
+				<input name="give_user_login" id="give_user_login" class="give-required give-input" type="text" />
 			</div>
+
 			<div class="give-login-password give-login">
 				<label for="give_user_pass"><?php esc_html_e( 'Password', 'give' ); ?></label>
 				<input name="give_user_pass" id="give_user_pass" class="give-password give-required give-input" type="password" />
@@ -37,7 +38,7 @@
 			</div>
 
 			<div class="give-lost-password give-login">
-				<a href="<?php echo wp_lostpassword_url(); ?>" title="<?php esc_attr_e( 'Lost Password', 'give' ); ?>"><?php esc_html_e( 'Lost Password?', 'give' ); ?></a>
+				<a href="<?php echo wp_lostpassword_url(); ?>"><?php esc_html_e( 'Lost Password?', 'give' ); ?></a>
 			</div>
 			<?php
 			/**

diff --git a/templates/shortcode-register.php b/templates/shortcode-register.php
@@ -34,12 +34,12 @@
 
 		<div class="form-row form-row-first">
 			<label for="give-user-login"><?php esc_html_e( 'Username', 'give' ); ?></label>
-			<input id="give-user-login" class="required give-input" type="text" name="give_user_login" title="<?php esc_attr_e( 'Username', 'give' ); ?>" />
+			<input id="give-user-login" class="required give-input" type="text" name="give_user_login" />
 		</div>
 
 		<div class="form-row form-row-last">
 			<label for="give-user-email"><?php esc_html_e( 'Email', 'give' ); ?></label>
-			<input id="give-user-email" class="required give-input" type="email" name="give_user_email" title="<?php esc_attr_e( 'Email Address', 'give' ); ?>" />
+			<input id="give-user-email" class="required give-input" type="email" name="give_user_email" />
 		</div>
 
 		<div class="form-row form-row-first">