Fix: remove required token key breaking PayPal connections (#7276)

Co-authored-by: Jon Waldstein <jon@givewp.com> Co-authored-by: Jon Waldstein <jonwaldstein@jwaldstein-mbp.mynetworksettings.com>
impress-org · Mar 6, 2024 · a8166d1 · a8166d1
1 parent 829ffa8
commit a8166d1
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 10 deletions.
diff --git a/give.php b/give.php
@@ -6,7 +6,7 @@
  * Description: The most robust, flexible, and intuitive way to accept donations on WordPress.
  * Author: GiveWP
  * Author URI: https://givewp.com/
- * Version: 3.5.0
+ * Version: 3.5.1
  * Requires at least: 6.0
  * Requires PHP: 7.2
  * Text Domain: give
@@ -403,7 +403,7 @@ private function setup_constants()
     {
         // Plugin version.
         if (!defined('GIVE_VERSION')) {
-            define('GIVE_VERSION', '3.5.0');
+            define('GIVE_VERSION', '3.5.1');
         }
 
         // Plugin Root File.

diff --git a/readme.txt b/readme.txt
@@ -5,7 +5,7 @@ Tags: donation, donate, recurring donations, fundraising, crowdfunding
 Requires at least: 6.0
 Tested up to: 6.4
 Requires PHP: 7.2
-Stable tag: 3.5.0
+Stable tag: 3.5.1
 License: GPLv3
 License URI: http://www.gnu.org/licenses/gpl-3.0.html
 
@@ -262,6 +262,9 @@ The 2% fee on Stripe donations only applies to donations taken via our free Stri
 10. Use almost any payment gateway integration with GiveWP through our add-ons or by creating your own add-on.
 
 == Changelog ==
+= 3.5.1: March 6th, 2024 =
+* Fix: Resolved an issue with PayPal that was preventing the ability to connect a PayPal account to GiveWP.
+
 = 3.5.0: February 29th, 2024 =
 * Security: Resolved a couple potential security vulnerabilities
 * New: Added the ability to add a header image to forms in the Visual Form Builder

diff --git a/src/PaymentGateways/PayPalCommerce/Repositories/PayPalAuth.php b/src/PaymentGateways/PayPalCommerce/Repositories/PayPalAuth.php
@@ -222,6 +222,7 @@ public function getSellerRestAPICredentials($accessToken)
      *
      * Sample PayPal access token: https://developer.paypal.com/api/rest/authentication/#link-sampleresponse
      *
+     * @since 3.5.1 removed app_id from required keys as PayPal no longer supplies it
      * @since 2.25.0
      *
      * @param array $accessToken Access token response from PayPal.
@@ -235,7 +236,6 @@ private function validateAccessToken(array $accessToken)
             'scope',
             'access_token',
             'token_type',
-            'app_id',
             'expires_in',
             'nonce'
         ];

diff --git a/tests/Feature/FormMigration/TestFormMetaDecorator.php b/tests/Feature/FormMigration/TestFormMetaDecorator.php
@@ -152,7 +152,7 @@ public function testHasFundOptionsShouldReturnTrue(): void
     }
 
     /**
-     * @unreleased
+     * @since 3.5.0
      */
     public function testGetFormFeaturedImageForSequoiaTemplate()
     {
@@ -189,7 +189,7 @@ public function testGetFormFeaturedImageForSequoiaTemplate()
     }
 
     /**
-     * @unreleased
+     * @since 3.5.0
      */
     public function testGetFormFeaturedImageForClassicTemplate()
     {
@@ -226,7 +226,7 @@ public function testGetFormFeaturedImageForClassicTemplate()
     }
 
     /**
-     * @unreleased
+     * @since 3.5.0
      */
     public function testGetFormFeaturedImageForLegacyTemplate()
     {
@@ -254,7 +254,7 @@ public function testGetFormFeaturedImageForLegacyTemplate()
     /**
      * @see https://core.trac.wordpress.org/browser/branches/4.5/tests/phpunit/tests/post/attachments.php#L24
      *
-     * @unreleased
+     * @since 3.5.0
      */
     private function uploadTestImage()
     {

diff --git a/tests/Unit/DonationForms/Actions/TestConvertDonationFormBlocksToFieldsApi.php b/tests/Unit/DonationForms/Actions/TestConvertDonationFormBlocksToFieldsApi.php
@@ -135,7 +135,7 @@ static function ($node, BlockModel $block, int $blockIndex) {
     }
 
     /**
-     * @unreleased
+     * @since 3.5.0
      *
      * @throws Exception
      */

diff --git a/tests/Unit/Framework/Models/TestEagerLoader.php b/tests/Unit/Framework/Models/TestEagerLoader.php
@@ -9,7 +9,7 @@
 use Give\Tests\TestTraits\RefreshDatabase;
 
 /**
- * @unreleased
+ * @since 3.5.0
  */
 class TestEagerLoader extends TestCase
 {