fix: improve code as optional param is now required so no conditions

impress-org · Jan 8, 2019 · e449346 · e449346
1 parent f2f10dc
commit e449346
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/includes/admin/tools/export/give-export-donations-functions.php b/includes/admin/tools/export/give-export-donations-functions.php
@@ -192,12 +192,8 @@ function give_export_donation_form_search_args( $args ) {
 	$fields = isset( $_POST['fields'] ) ? $_POST['fields'] : null;
 
 	// Using parse_str() function without the result parameter is highly DISCOURAGED and DEPRECATED as of PHP 7.2.
-	if ( version_compare( phpversion(), '7.2.0', '>=' ) ) {
-		$fields_result_array = array();
-		parse_str( $fields, $fields_result_array );
-	} else {
-		parse_str( $fields );
-	}
+	$fields_result_array = array();
+	parse_str( $fields, $fields_result_array );
 
 	if ( ! empty( $give_forms_categories ) || ! empty( $give_forms_tags ) ) {
 		$args['posts_per_page'] = - 1;