Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Tags Issues Across Several Add-ons #1030

Closed
mathetos opened this issue Sep 15, 2016 · 1 comment
Closed

Email Tags Issues Across Several Add-ons #1030

mathetos opened this issue Sep 15, 2016 · 1 comment

Comments

@mathetos
Copy link
Member

We currently have a few open issues related to email tags. This affects primarily

  • Form Field Manager
  • PDF Receipts
  • Recurring Donations

Here's a quick list:

CORE

  1. Do string_replace for all registered email tags, not just {email} #611

FFM

  1. https://github.com/WordImpress/Give-Form-Field-Manager/issues/35
  2. https://github.com/WordImpress/Give-Form-Field-Manager/issues/39

PDF Receipts

  1. https://github.com/WordImpress/Give-PDF-Receipts/issues/43
  2. https://github.com/WordImpress/Give-PDF-Receipts/issues/65

Recurring

  1. https://github.com/WordImpress/Give-Recurring-Donations/issues/233
  2. https://github.com/WordImpress/Give-Recurring-Donations/issues/198

I'm wondering if there's something we can do in Core to help resolve all these issues and prevent issues like these from cropping up in the future. Perhaps the way we render email tags in email content areas or PDF receipts can be consolidated into one base helper function. Not sure, just seems like we can be smarter about this.

@DevinWalker
Copy link
Member

Closing in favor of: #1346

We will address and explain conditional email template tags and their usage across various emails within that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants