Refactor Core Email Settings

[DevinWalker]

Issue Overview

@ravinderk and I discussed revamping Give's email functionality so that it is more flexible and easy to work with.

Related Issues
#1215
#1030
#611
#1607
#1623

[mathetos]

WOOT! +1000 on this!!

👍 👍 👍 👍 👍

[kevinwhoffman]

This will be really helpful to have all email settings accessible from one place. Here are a couple suggestions.

See WooCommerce example. Table looks cleaner when descriptions are displayed in tooltips.

[DevinWalker]

I agree @kevinwhoffman - if we can also customize the cog icon so it's a button as well that would make it even cleaner:

[mathetos]

@DevinWalker Would love a button that says "Edit Email" instead of the cog.

[kevinwhoffman]

Do you think it makes sense to stick closer to the WP Core UI, where hovering over the row displays links? I can see it being helpful to preview the email directly from this screen, rather than having to click into settings and scroll down to find the preview button.

[mathetos]

Hmmm.... I like that idea. Here's all the ideas all in one:

1. The checkmark enables/disables the email dynamically without a page refresh
2. The descriptions are moved to the tooltips rather than inline below
3. Hovering over the title shows the "Edit | Preview" links
4. Clicking the "Preview" link opens the email in a modal -- no page refresh
5. Recipient can be changed directly, and {tags} can be used. This would update similar to how QuickEdit works in WordPress Core on Pages/Posts
6. I think having the additional "Edit Email" button at the end is just helpful since the "Edit" is hidden by default until hovering.

[DevinWalker]

Nice feedback and revisions.

1. Yes
2. Yes
3. Yes
4. This will just open a new window like it does for now. We can update it to open a modal later.
5. I don't like this option so much. It looks like our shortcode's click-to-copy field and people aren't really going to be changing the recipients very often so there's not really a need to quick edit.
6. I like using an icon rather than text

[ravinderk]

@DevinWalker I showed description under title because we are following the same pattern for core setting. Let me know if you still want to change them

[DevinWalker]

@ravinderk for the new email settings it looks better to use tooltips for the descriptions. It just looks a lot better when it's in a table.

[ravinderk]

@DevinWalker Alright. I will update UI as suggested.