Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lingering bugs with Settings tab dropdown #1544

Closed
2 tasks done
DevinWalker opened this issue Feb 24, 2017 · 1 comment
Closed
2 tasks done

Lingering bugs with Settings tab dropdown #1544

DevinWalker opened this issue Feb 24, 2017 · 1 comment
Assignees
@DevinWalker @ravinderk
Milestone
1.8.6

Comments

@DevinWalker
Copy link
Member

DevinWalker commented Feb 24, 2017 •
edited
Loading

Issue Overview

  • Alignment gets screwy when you play with the window and RTL
  • Improve show/hide bugs - currently if you click open using the button and close it using the button and click anywhere outside, the menu will open again.

Expected Behavior

No strange alignment issues with usability

Current Behavior

Buggy UX
@DevinWalker DevinWalker added this to the 1.8.3 milestone Feb 24, 2017
@ravinderk ravinderk mentioned this issue Feb 24, 2017
Merged
3 tasks
@DevinWalker DevinWalker modified the milestones: 1.8.3, 1.8.4, 1.8.5 Feb 25, 2017
@ravinderk ravinderk mentioned this issue Mar 3, 2017
Merged
3 tasks
DevinWalker pushed a commit that referenced this issue Mar 3, 2017
Merge pull request #1562 from ravinderk/issues/1544
771afee 
Fix #1544
@DevinWalker
Copy link
Member Author

It's working pretty nice now. One last thing is that on mobile resolutions the dropdown should be full width.

@ravinderk ravinderk mentioned this issue Mar 4, 2017
Closed
3 tasks
@DevinWalker DevinWalker modified the milestones: 1.8.5, 1.8.6 Mar 15, 2017
DevinWalker pushed a commit that referenced this issue Apr 10, 2017
Basic fix for responsive dropdown #1544
27508e3
DevinWalker pushed a commit that referenced this issue Apr 10, 2017
Additional adjustments to responsive handling #1544
ecea84d
@DevinWalker DevinWalker mentioned this issue Apr 10, 2017
Merged
3 tasks
DevinWalker pushed a commit that referenced this issue Apr 10, 2017
Merge branch 'master' into mathetos-release/1.9
84f8219 
* master: (36 commits)
  New POT file for 1.8.6
  Gulp
  Additional adjustments to responsive handling #1544
  Typo fix
  Basic fix for responsive dropdown #1544
  Versions updated and readme added for 1.8.6
  Removing during tests
  Still testing
  Remove codesniffer for now
  Updating composer.json to fix 7.1 error
  New .gitattributes file export ignore file - brought over from Woo New PHPCS ruleset - brought over from Woo
  Fix: stop firing additional ajax request while choosing form for exporting donors
  Fix: php notices which comes when requesting for form levels by ajax
  Update: run gulp concat_scripts
  Add: global js to toggle terms
  Remove: inline toggle term and conditions js
  Fix: improve code formatting
  Fix: php compatibility releated issue of code
  Update:  should be an array
  Refacter: multi donation form payment test
  ...

# Conflicts:
#	assets/css/give-admin-rtl.min.css
#	assets/css/give-admin.min.css
#	assets/js/admin/admin-scripts.min.js
#	assets/js/frontend/give.all.min.js
#	assets/sourcemaps/give-admin.css.map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevinWalker DevinWalker

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.8.6
Development

No branches or pull requests
2 participants
@DevinWalker @ravinderk