Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure core version updates run in a proper order #1626

Closed
DevinWalker opened this issue Apr 18, 2017 · 0 comments
Closed

Ensure core version updates run in a proper order #1626

DevinWalker opened this issue Apr 18, 2017 · 0 comments
Assignees
@ravinderk
Milestone
1.8.7

Comments

@DevinWalker
Copy link
Member

Issue Overview

There is a break statement within the switch here: https://github.com/WordImpress/Give/blob/master/includes/admin/upgrades/upgrade-functions.php#L40 which is preventing updates from running properly.

Expected Behavior

If updated from 1.5 to 1.8 all updates run.

Current Behavior

Only the first update will run.

Possible Solution

Remove breaks

Steps to Reproduce (for bugs)

  1. Install old version 1.5
  2. Activate
  3. View if all updates ran
@DevinWalker DevinWalker added this to the 1.8.7 milestone Apr 18, 2017
ravinderk added a commit to ravinderk/Give that referenced this issue Apr 19, 2017
@ravinderk
Fix: impress-org#1626
7ac2e1b
@ravinderk ravinderk mentioned this issue Apr 19, 2017
Merged
3 tasks
DevinWalker pushed a commit that referenced this issue Apr 19, 2017
Merge pull request #1628 from ravinderk/issues/1626
6d236df 
Fix: #1626
@Benunc Benunc mentioned this issue Jan 7, 2019
Closed
5 tasks
@Benunc Benunc mentioned this issue Jan 30, 2019
Closed
6 tasks
@Benunc Benunc mentioned this issue Feb 28, 2019
Closed
6 tasks
This was referenced Mar 13, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.8.7
Development

No branches or pull requests
2 participants
@DevinWalker @ravinderk