Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an add-on license is deactivated it should be remove from field and database #1649

Closed
DevinWalker opened this issue May 4, 2017 · 0 comments
Closed

When an add-on license is deactivated it should be remove from field and database #1649

DevinWalker opened this issue May 4, 2017 · 0 comments
Assignees
@ravinderk
Milestone
1.8.7

Comments

@DevinWalker
Copy link
Member

DevinWalker commented May 4, 2017 •
edited
Loading

Issue Overview

When a license is deactivated it should no longer appear within the license field:

2017-05-03_18-16-07

Started investigating in PR: https://github.com/WordImpress/Give/tree/issue/1648

Expected Behavior

When deactivated, the license is removed and deactivated.

Current Behavior

License remains in database and is exposed without being pw protected to donor.

Possible Solution

Determine why it is not being deleted properly.

Steps to Reproduce (for bugs)

  1. Install Give + Add-ons
  2. Activate and deactivate a license
  3. View field within tab

Related Issues and/or PRs

#1586
@DevinWalker DevinWalker added the bug label May 4, 2017
@DevinWalker DevinWalker added this to the 1.8.7 milestone May 4, 2017
@ravinderk ravinderk mentioned this issue May 4, 2017
Merged
3 tasks
@ravinderk ravinderk mentioned this issue May 4, 2017
Closed
3 tasks
DevinWalker added a commit that referenced this issue May 4, 2017
@DevinWalker
Touched up the CSS so that notices are in the same container #1649
5bf9fbc
DevinWalker added a commit that referenced this issue May 4, 2017
@DevinWalker
Allow messages to be in the same container
3d81487 
Display name of the add-on in the notice #1649
DevinWalker added a commit that referenced this issue May 4, 2017
@DevinWalker
Fixed bug with license key not being saved to settings properly #1649
d4745d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravinderk ravinderk

Labels
None yet
Projects
None yet
Milestone
1.8.7
Development

No branches or pull requests
2 participants
@DevinWalker @ravinderk