Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache direct queries and objects #1944

Closed
2 tasks
ravinderk opened this issue Aug 2, 2017 · 3 comments
Closed
2 tasks

Cache direct queries and objects #1944

ravinderk opened this issue Aug 2, 2017 · 3 comments
Assignees
Milestone

Comments

@ravinderk
Copy link
Collaborator

ravinderk commented Aug 2, 2017

Issue Overview

Direct queries made with `$wpdb', Give_Donor and Give_Payment do not cache automatically. We can cache them to improve performance.
For example, Donor related queries currently are uncached.
( I will update this after some more research )

Similar #2121

Todos

  • Tests
  • Documentation
@ravinderk ravinderk added this to the 2,1 milestone Aug 2, 2017
@ravinderk ravinderk self-assigned this Aug 2, 2017
@ravinderk ravinderk modified the milestones: 2,1, 2.1 Aug 2, 2017
@ravinderk ravinderk changed the title Cache direct queries Cache direct queries and objects Aug 15, 2017
@ravinderk ravinderk modified the milestones: 2.0, 2.1 Aug 15, 2017
@ravinderk ravinderk modified the milestones: 2.1, 2.0 Nov 2, 2017
@ravinderk ravinderk mentioned this issue Nov 21, 2017
3 tasks
@mathetos
Copy link
Member

@ravinderk Will we be able to clear this cache with a button similar to our "Refresh Reports" button? Users very often want to see the latest data accurately reflected pretty much everywhere in WP Admin. I love things to be able to load more quickly for sure, but users will want accurate data reporting as well.

@ravinderk
Copy link
Collaborator Author

@mathetos Cache will automatically get flush when an update occurs in form, donor, and donation. Currently, cache logic is limited to donations and donor only. I will ask you to review when PR will be ready then tell me if you still need cache flush button.

@ravinderk
Copy link
Collaborator Author

@DevinWalker Closing this PR for now. I will reopen this if I will find any issue related to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants