Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/1944 #2374

Merged
merged 175 commits into from
Dec 13, 2017
Merged

Issues/1944 #2374

merged 175 commits into from
Dec 13, 2017

Conversation

ravinderk
Copy link
Collaborator

@ravinderk ravinderk commented Nov 21, 2017 •
edited
Loading

Description

This will resolve
#1944
#2464

How Has This Been Tested?

Manually by performing following operations:

  1. Form update
  2. Donor create/update/delete
  3. Payment update
  4. .... [Addon testing]

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@ravinderk
Add new caching method
f66fbed
@ravinderk
Add caching logic for payment
22f0f04
@ravinderk
Update last_updated meta key when cpt updated
0ecaff7
@ravinderk
Cache donor query
b4a4172
@ravinderk
Cache donor object
fe8a78d
@ravinderk
Add get_group cache fx
bb82df6
@ravinderk
Update set_cache fx usage
2fe2f45
@ravinderk
Add global constant to disable cache
ed1f64c
@ravinderk
Add todo
5091ce9
@ravinderk
Remove cache when cpt payment meta updated
b67f3a7
@ravinderk
Merge branch 'release/2.0' into issues/1944
bdb3277
@ravinderk
Merge branch 'release/1.8.17' into release/2.0
f6b7e7a
@ravinderk
Merge branch 'release/2.0' into issues/1944
ea3a597
@ravinderk
Remo duplicate give_get_attribute_str fx defination
12d47f8
@ravinderk
Merge branch 'release/2.0' into issues/1944
3b3ad9b
@ravinderk
Update get all payment meta backward compatibility code
a9d5034
@ravinderk
Merge branch 'release/2.0' into issues/1944
ae4a194
@ravinderk
Merge branch 'release/1.8.17' into release/2.0
195d193
@ravinderk
Merge branch 'release/2.0' into issues/1944
4023a61
@ravinderk
Increate get_post_metadata priority to save fro conflict
68312b3
@ravinderk
Merge branch 'release/1.8.17' into release/2.0
be7c9d6
@ravinderk
Merge branch 'release/2.0' into issues/1944
ef3669c
@ravinderk
Fix broken unit tests
48875cd
@ravinderk
Merge branch 'release/2.0' into issues/1944
7eaf820
@ravinderk
Merge branch 'release/2.0' into issues/1944
b2a9779
@ravinderk
add gibe_get_attribute_str undefined fn
662ebe4
@ravinderk
Merge branch 'release/2.0' into issues/1944
acd59b3
@ravinderk
Merge branch 'release/2.0' into issues/1944
0c64743
@ravinderk
Update fn docs
53dff99
@ravinderk
Refactor get_group cache helper fn
a81e98c
@ravinderk
Merge branch 'release/2.0' into issues/1944
0b9c484
@ravinderk
Merge branch 'release/2.0' into issues/1944
405ad37
@ravinderk
Merge branch 'release/2.0' into issues/1944
9ba5810
@ravinderk
Merge branch 'release/2.0' into issues/1944
5bd2ab7 
Conflicts:
	includes/payments/class-give-payment.php
	includes/payments/class-payments-query.php
	includes/payments/functions.php
@ravinderk
Merge remote-tracking branch 'origin/issues/1944' into issues/1944
986f5c1 
 Conflicts:
	includes/payments/class-payments-query.php
@ravinderk
Merge branch 'release/2.0' into issues/1944
1aa36b9 
Conflicts:
	includes/admin/upgrades/upgrade-functions.php
	includes/payments/actions.php
	includes/payments/backward-compatibility.php
@ravinderk
Merge branch 'release/2.0' into issues/1944
2398f63 
# Conflicts:
#	includes/payments/backward-compatibility.php
@ravinderk
Add missing code from code conflict
0f5ced1
mehul0810
mehul0810 suggested changes Dec 6, 2017
View reviewed changes
includes/admin/settings/class-settings-advanced.php
'disabled' => __( 'Disabled', 'give' ),
),
),
array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravinderk This settings ( i.e. Remove Data on Uninstall) is duplicated in this PR. This happens when i add this PR to Give release 2.0

Check Screenshot for reference:
image

@mehul0810
Copy link
Contributor

@ravinderk I think we should add option to show the status of Caching under System Info. This will help us in debugging when any customer report any issue after Give 2.0 is LIVE. Let me know your thoughts.

@ravinderk
Copy link
Collaborator Author

@mehul0810 Good Idea

@ravinderk
Copy link
Collaborator Author

@mehul0810 Added.
screen shot 2017-12-06 at 6 24 37 pm

@ravinderk
Merge branch 'release/2.0' into issues/1944
d23c78c 
 Conflicts:
	includes/admin/upgrades/upgrade-functions.php
	includes/payments/actions.php
	includes/payments/backward-compatibility.php
	includes/payments/class-give-payment.php
@ravinderk
Merge remote-tracking branch 'origin/issues/1944' into issues/1944
17f6a6d 
 Conflicts:
	includes/payments/actions.php
	includes/payments/backward-compatibility.php
@ravinderk
Merge branch 'release/2.0' into issues/1944
d66064d
@emgk
Copy link
Contributor

emgk commented Dec 7, 2017

@ravinderk I am getting PHP notice when open add donation form page in the backend.

Notice: Undefined index: key in /app/public/wp-content/plugins/Give/includes/payments/backward-compatibility.php on line 583

https://github.com/ravinderk/Give/blob/issues/1944/includes/payments/backward-compatibility.php#L583

@ravinderk ravinderk merged commit 226f1f9 into impress-org:release/2.0 Dec 13, 2017
@ravinderk ravinderk mentioned this pull request Dec 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehul0810 mehul0810 mehul0810 requested changes

@DevinWalker DevinWalker Awaiting requested review from DevinWalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ravinderk @mehul0810 @emgk