Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading scripts in footer #209

Closed
ibndawood opened this issue Aug 17, 2015 · 3 comments
Closed

Loading scripts in footer #209

ibndawood opened this issue Aug 17, 2015 · 3 comments
Assignees
Milestone

Comments

@ibndawood
Copy link
Contributor

I notice that the give scripts are being loaded in header. I think it is best loaded in footer. Your thoughts ?

@DevinWalker
Copy link
Member

I think an option to move to the footer under Settings > Advanced would be best

@DevinWalker
Copy link
Member

The problem with loading scripts in the footer sometimes is a Flash of Unstyled Content (FOUC) - which can lead to more support requests...

I think an advanced option would be a nice addition...

@mathetos
Copy link
Member

mathetos commented Sep 1, 2015

Had a Twitter convo about this as well:
https://twitter.com/bendelaney/status/636930070842478592

@DevinWalker DevinWalker added this to the 1.3 Milestone milestone Sep 1, 2015
@DevinWalker DevinWalker self-assigned this Sep 3, 2015
DevinWalker pushed a commit that referenced this issue Sep 3, 2015
New option to load scripts in the footer Fixes #209
jonwaldstein pushed a commit to jonwaldstein/givewp that referenced this issue Aug 15, 2023
* feature: add terms and conditions block to form builder

* feature: add consent prop types

* Feature: add consent field to fields api

* feature: convert consent block to fields api

* feature: create node from consent block

* feature: render consent field templates

* feature: include consent field in registrars

* feature: include interweave to render custom agreement texts

* feature: scoll modal into view

* chore: update import path for Editor

* fix: update to correct attribute name

* refactor: render link text on all display styles

* fix: render interweave for agreement text inside show form display

* chore: remove unused isFormDisplay conditional

* feature: add validation rule for T&C block

* refactor: hide ShowTerms button when terms are revealed

* fix: change GiveWP case

* refactor: simplify file import

* refactor: remove imports from React

* fix: add fall back background color to modal

---------

Co-authored-by: Paulo Iankoski <me@wpdev.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants