Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer: "Postal Code" should auto-map to "Zip" #2164

Closed
mathetos opened this issue Oct 4, 2017 · 6 comments
Closed

Importer: "Postal Code" should auto-map to "Zip" #2164

mathetos opened this issue Oct 4, 2017 · 6 comments
Milestone
1.8.15

Comments

@mathetos
Copy link
Member

mathetos commented Oct 4, 2017

Issue Overview

It is universally understood that "Postal Code" is another term for "Zip". We should auto-map that.

Expected Behavior

That "Postal Code" is auto-mapped to "Zip"

Current Behavior

It currently isn't:
image
@BhargavBhandari90
Copy link
Contributor

@mathetos
Which csv do we need to import for this? Can you share file or something.

@mathetos
Copy link
Member Author

mathetos commented Oct 9, 2017

@BhargavBhandari90 -- I'd suggest taking any CSV you have available, then change the header from "Zip" to "Postal Code" and test with that.

BhargavBhandari90 added a commit to BhargavBhandari90/Give that referenced this issue Oct 11, 2017
@BhargavBhandari90
Fix - issue impress-org#2164
d45d813 
Map postal code to zip during importing
BhargavBhandari90 added a commit to BhargavBhandari90/Give that referenced this issue Oct 11, 2017
@BhargavBhandari90
Fix - issue impress-org#2164
964ee74 
Map postal code to zip during importing
BhargavBhandari90 added a commit to BhargavBhandari90/Give that referenced this issue Oct 11, 2017
@BhargavBhandari90
Fix - issue impress-org#2164
a3c3ff0 
Map postal code to zip during importing
BhargavBhandari90 added a commit to BhargavBhandari90/Give that referenced this issue Oct 11, 2017
@BhargavBhandari90
Merge branch 'release/1.8.14' into issue/impress-orgGH-2164
b483b59
BhargavBhandari90 added a commit to BhargavBhandari90/Give that referenced this issue Oct 11, 2017
@BhargavBhandari90
Fix - issue impress-org#2164
a228d63 
Map postal code to zip during importing
@DevinWalker DevinWalker added this to the 1.8.15 milestone Oct 11, 2017
@DevinWalker
Copy link
Member

@BhargavBhandari90 you can check out https://docs.google.com/spreadsheets/d/1ighe7VM6f8oVACjPlL12qB8LdKoneIgo4fEyYxeUOt8/edit?usp=sharing as well - it's an example import file

@BhargavBhandari90
Copy link
Contributor

I saw this task is assigned to @raftaar1191. Should I continue on this?

@ravinderk
Copy link
Collaborator

@BhargavBhandari90 You can continue 👍

@BhargavBhandari90 BhargavBhandari90 mentioned this issue Oct 13, 2017
Merged
3 tasks
@ravinderk ravinderk reopened this Oct 17, 2017
@ravinderk
Copy link
Collaborator

The solution provided by @BhargavBhandari90 was not flexible. As per discuss with @DevinWalker and @raftaar1191 we can improve this.

Image provided by @raftaar1191

pasted image at 2017_10_17 11_45 am

raftaar1191 added a commit to raftaar1191/Give that referenced this issue Oct 17, 2017
@raftaar1191
Add Multi label function check impress-org#2164
86654fb
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Oct 17, 2017
@raftaar1191
Add Zip and postal code multipal label option impress-org#2164
109090c
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Oct 17, 2017
@raftaar1191
Remove Repetation of code impress-org#2164
a9d1d67
@raftaar1191 raftaar1191 mentioned this issue Oct 17, 2017
Merged
3 tasks
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Oct 17, 2017
@raftaar1191
Refix Multi label function check impress-org#2164
39bf1af
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Oct 17, 2017
@raftaar1191
Add Country multipal label option impress-org#2164
4386c40
raftaar1191 added a commit to raftaar1191/Give that referenced this issue Oct 17, 2017
@raftaar1191
Use language translate fx impress-org#2164
b2fc23d
@BhargavBhandari90 BhargavBhandari90 mentioned this issue Oct 19, 2017
Closed
3 tasks
DevinWalker added a commit that referenced this issue Oct 19, 2017
@DevinWalker
Merge branch 'master' into release/1.8.16
1cd5d95 
* master: (367 commits)
  1. Added changlog 2. Bumped stable tag to 1.8.15 3. Ran gulp and gulp POT
  Removed error_log and added @Updated
  Resolved issue with endless looping because of URL mismatches.
  Formatting improvements
  fix php-doc for give_update_meta
  Fix typo in phpunit test
  Fix EUR default formatting settings
  Improve condition in give_get_currency_formatting_settings fx
  Pass currency code instead of donation id to give_format_amount
  Improve code doc
  Use currency code to get formatting settings rather then id
  give_amount_format does not accept third param
  Improve history page column content code
  Refactor history page table header code
  Use language translate fx #2164
  Improve get_columns function
  Fix typo
  Improve code formatting
  Use language translate fx
  Improve code formatting
  ...

# Conflicts:
#	give.php
#	readme.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.15
Development

No branches or pull requests
5 participants
@mathetos @DevinWalker @ravinderk @BhargavBhandari90 @raftaar1191