Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): float labels result in too little contrast for inactive placeholders. #2179

Closed
1 task
Benunc opened this issue Oct 10, 2017 · 1 comment
Closed
1 task
Assignees

Comments

@Benunc
Copy link
Member

Benunc commented Oct 10, 2017

Issue Overview

Float labels enabled makes the contrast too low on placeholders.

Expected Behavior

There should be enough contrast to read.

Current Behavior

There's not enough contrast for accessibility, or comfortable reading in general.

Possible Solution

revert to #333 as the color there.

Expand for a temporary snippet @kevinwhoffman made:

.fl-form input.fl-input:-moz-placeholder,
[id*=give-form] .fl-form select.fl-select:-moz-placeholder,
[id*=give-form] .fl-form textarea.fl-textarea:-moz-placeholder {
    color: #333
}
[id*=give-form] .fl-form input.fl-input::-moz-placeholder,
[id*=give-form] .fl-form select.fl-select::-moz-placeholder,
[id*=give-form] .fl-form textarea.fl-textarea::-moz-placeholder {
    color: #333
}
[id*=give-form] .fl-form input.fl-input:-ms-input-placeholder,
[id*=give-form] .fl-form select.fl-select:-ms-input-placeholder,
[id*=give-form] .fl-form textarea.fl-textarea:-ms-input-placeholder {
    color: #333
}
[id*=give-form] .fl-form input.fl-input::-webkit-input-placeholder,
[id*=give-form] .fl-form select.fl-select::-webkit-input-placeholder,
[id*=give-form] .fl-form textarea.fl-textarea::-webkit-input-placeholder {
    color: #333
}
[id*=give-form] .fl-form select.fl-select {
    color: #333;
}
[id*=give-form] .fl-form label.fl-label {
    color: #333;
}

Steps to Reproduce (for bugs)

  1. running 1.8.13, enable floated labels.
  2. view the form
  3. inspect in dev tools to see that the color is #bbb when it should be #333

Related Issues and/or PRs

#2155

Todos

  • Tests
@kevinwhoffman
Copy link
Contributor

I recommend #757575 for placeholder text. It is a light gray but still meets WCAG AA standards.

@DevinWalker DevinWalker changed the title Float Labels result in too little contrast for inactive placeholders. fix(form): float Labels result in too little contrast for inactive placeholders. Aug 1, 2018
@DevinWalker DevinWalker changed the title fix(form): float Labels result in too little contrast for inactive placeholders. fix(form): float labels result in too little contrast for inactive placeholders. Aug 1, 2018
ravinderk added a commit that referenced this issue Aug 6, 2018
fix(form): float labels result in too little contrast for inactive placeholders. #2179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants