Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(donor): create singular method to delete donor #2347

Closed
3 tasks done
mehul0810 opened this issue Nov 16, 2017 · 2 comments
Closed
3 tasks done

refactor(donor): create singular method to delete donor #2347

mehul0810 opened this issue Nov 16, 2017 · 2 comments
Assignees

Comments

@mehul0810
Copy link
Contributor

mehul0810 commented Nov 16, 2017

Issue Overview

Currently, there are many different ways used to delete donor. However, to overcome this issue we require a unified function with which donor deletion can be managed and made extensible.

Check Document for more details: https://docs.google.com/document/d/1opVjPivmtxHk-MTSw39WDFma3PgQetoTVRt-4FciB5w/edit#

Expected Behavior

Create an extensible and unique function to manage donor deletion process.

Current Behavior

Managed via multiple functions.

Todos

  • Investigate
  • Fix
  • Write post on developers.givewp.com
@ravinderk ravinderk added this to the 2.0.1 milestone Nov 16, 2017
@ravinderk ravinderk modified the milestones: 2.0.1, 2.0.2, 2.2 Jan 22, 2018
@DevinWalker DevinWalker removed this from the 2.2 milestone Mar 6, 2018
@kevinwhoffman kevinwhoffman changed the title Unify Donor Delete function to make it more extensible refactor(donor): create singular method to delete donor Mar 13, 2018
@impress-org impress-org deleted a comment from raftaar1191 May 9, 2018
@DevinWalker DevinWalker modified the milestones: Sprint: 2018/05/08 - 2018/05/22, Sprint: 2018/05/08 - 2018/06/05 May 23, 2018
DevinWalker pushed a commit that referenced this issue Jun 7, 2018
refactor(donor): create singular method to delete donor #2347
@DevinWalker
Copy link
Member

@mehul0810 can you draft a post on developers.givewp.com and I'll review - then we can close this one out.

@mehul0810
Copy link
Contributor Author

Slack Call Summary

Participants: @mehul0810 @ravinderk
Topic: Discussion on simplifying the tools section for donor delete
Result: It seems that the donor delete process fn missed out for tools section in admin. So, I'll create another function which specifically deletes donors and payments without redirect which will help us unify the process. So, I'll create a new PR to manage this functionality and then will create a detail developers blog post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants